[JAVA-3604] OSGi: Make mongodb-driver-sync dependency on mongodb-crypt optional Created: 24/Jan/20 Updated: 28/Oct/23 Resolved: 31/Jan/20 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | Build, Client Side Encryption |
| Affects Version/s: | 3.12.1 |
| Fix Version/s: | 3.12.2, 4.0.0 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Josef Haertl | Assignee: | Ross Lawley |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Java with OSGi |
||
| Description |
|
This seems quite similar and/or an follow-up to The manifest.xml of mongodb-driver-sync declares a required import of
... which would be provided by mongodb-crypt This is odd for multiple reasons
Probably
should be declared optional? |
| Comments |
| Comment by Josef Haertl [ 31/Jan/20 ] |
|
Great! Thanks for fixing this so quickly |
| Comment by Ross Lawley [ 31/Jan/20 ] |
|
This will be released in 3.12.2 |
| Comment by Githook User [ 30/Jan/20 ] |
|
Author: {'name': 'Ross Lawley', 'username': 'rozza', 'email': 'ross.lawley@gmail.com'}Message: OSGI: Mark com.mongodb.crypt.capi as optional Bnd needs some help marking optional dependency packages as optional.
|
| Comment by Githook User [ 30/Jan/20 ] |
|
Author: {'name': 'Ross Lawley', 'username': 'rozza', 'email': 'ross.lawley@gmail.com'}Message: OSGI: Mark com.mongodb.crypt.capi as optional The OSGI plugin needs some help marking optional dependency packages as optional.
|
| Comment by Ross Lawley [ 30/Jan/20 ] |
|
PR: https://github.com/rozza/mongo-java-driver/pull/361 (3.12.2) |
| Comment by Ross Lawley [ 30/Jan/20 ] |
| Comment by Josef Haertl [ 27/Jan/20 ] |
|
Hi Ross Lawley, Yes, with "Currently there is no maven dependency at all" i meant that the (optional) dependency is not picked up while not beeing marked as optional. So, currently, one has to best guess that mongodb-crypt must be added in the maven build (as a workaround for now - on the long term, making it optional would be greatly prefereable) Thanks for investigating Josef Härtl |
| Comment by Ross Lawley [ 24/Jan/20 ] |
|
Hi josef.haertl@ldbv.bayern.de, Thanks for the ticket. Your correct the MongoCrypt dependency is an optional dependency of mongodb-driver-core and if the configuration uses encryption then it will be used by mongodb-driver-sync. Unfortunately,
Just to clarify; Is this because the optional dependency from driver-core won't be picked up by maven and in mongodb-driver-sync its not marked as optional? Apologies for missing this in the higher level MANIFESTs. Ross |