[JAVA-3927] Rate limit new connection creations (maxConnecting) Created: 10/Jan/21 Updated: 28/Oct/23 Resolved: 14/Apr/21 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | Connection Management |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Esha Bhargava | Assignee: | Valentin Kavalenka |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Avoiding connection storms | ||||||||||||||||||||||||||||||||||||||||
| Quarter: | FY22Q4 | ||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||
| Documentation Changes: | Not Needed | ||||||||||||||||||||||||||||||||||||||||
| Comments |
| Comment by senthil kumar c [ 23/Jan/23 ] |
|
Hi Ashni, Thanks for the reply. I have created new ticket as below, Thanks, Senthil |
| Comment by Ashni Mehta [ 17/Jan/23 ] |
|
Hi Senthil, I chatted with the team about this one. Regarding the commit that you linked about deadlock, we don't believe that it is applicable specifically to the 3.12.9 driver version. Regarding the similar issue that you mention, I think it would be best to file a new ticket on this project with your driver/server version details and any additional information that you think might be helpful for us as we investigate. |
| Comment by senthil kumar c [ 13/Jan/23 ] |
|
Hi Ashni, It would be helpful us, if you provide an update on the above query. Thanks, Senthil |
| Comment by senthil kumar c [ 06/Jan/23 ] |
|
Hi Ashni, Thanks for the quick response. My query is, whether the reported issue is applicable for 3.12.9? Thanks, Senthil |
| Comment by Ashni Mehta [ 05/Jan/23 ] |
|
Hi Senthil, I believe this is available in 4.3.0 and later. |
| Comment by senthil kumar c [ 05/Jan/23 ] |
|
Hi All, Issue fixed as part of the below is applicable for 3.12.9 version? Can someone help on this. |
| Comment by Githook User [ 08/Jun/21 ] |
|
Author: {'name': 'Valentin Kovalenko', 'email': 'valentin.kovalenko@mongodb.com', 'username': 'stIncMale'}Message: Refactor `DefaultConnectionPool` to use single worker thread when checking out asynchronously (#722) When implementing https://github.com/mongodb/mongo-java-driver/commit/73e30857eed2f1d02ff7e9a6e5028d557a1cf4cf The solution to the problem I used is to submit tasks to different queues, which, However, there is another approach to solving the deadlock problem, If I realized that previously, I would have sacrificed this optimization This change also fixes reactive `MainTransactionsTest` runner
|
| Comment by Githook User [ 02/May/21 ] |
|
Author: {'name': 'Valentin Kovalenko', 'email': 'valentin.kovalenko@mongodb.com', 'username': 'stIncMale'}Message: Simplify `DefaultConnectionPool.OpenConcurrencyLimiter.tryLock` (#702) When locking for the purpose of using the wait/signal approach, The Java SE example for `java.util.concurrent.locks.Condition.awaitNanos`
|
| Comment by Githook User [ 01/May/21 ] |
|
Author: {'name': 'Valentin Kovalenko', 'email': 'valentin.kovalenko@mongodb.com', 'username': 'stIncMale'}Message: Fix deadlock and couple more problems in `DefaultConnectionPool` (#699) This commit fixes three problems in `DefaultConnectionPool`/`ConcurrentPool`:
Deadlock in `DefaultConnectionPool` a) Before introducing OpenConcurrencyLimiter, "AsyncGetter" thread was used only As a result, we may have a thread that gets the last connection (`maxSize` is reached) A solution is to do `ConcurrentPool.get` and `waitUntilOpenPermitAvailable` Potential unnecessary and harmful removal from `OpenConcurrencyLimiter.desiredConnectionSlots` If `acquirePermitOrGetAvailableOpenedConnection` is called with `true` as `tryGetAvailable`, Double release in `DefaultConnectionPool`/`ConcurrentPool` On one hand `ConcurrentPool.ensureMinSize` tries to not require the caller to do It is not easy (requires an additional knob and logic)
|
| Comment by Githook User [ 14/Apr/21 ] |
|
Author: {'name': 'Valentin Kovalenko', 'email': 'valentin.kovalenko@mongodb.com', 'username': 'stIncMale'}Message: Rate limit new connection creations (maxConnecting) (#685)
|