[JAVA-5033] Kotlin and Scala check task depends on spotlessApply Created: 22/Jun/23 Updated: 28/Oct/23 Resolved: 23/Jun/23 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | Build, Test Improvement |
| Affects Version/s: | None |
| Fix Version/s: | 4.10.1 |
| Type: | Improvement | Priority: | Unknown |
| Reporter: | Ross Lawley | Assignee: | Ross Lawley |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Documentation Changes: | Not Needed |
| Documentation Changes Summary: | 1. What would you like to communicate to the user about this feature? |
| Description |
|
While convenient, this does mean checked in source code (that hasn't run check) can be reformatted causing a build to be marked dirty. 1. Use a githook to run spotlessApply automagically. |
| Comments |
| Comment by Githook User [ 22/Jun/23 ] |
|
Author: {'name': 'Ross Lawley', 'email': 'ross.lawley@gmail.com', 'username': 'rozza'}Message: Scala: Fix spotless errors
|
| Comment by Githook User [ 22/Jun/23 ] |
|
Author: {'name': 'Ross Lawley', 'email': 'ross.lawley@gmail.com', 'username': 'rozza'}Message: Build: Ensure spotless checks are run Turn off automatic running of spotlessApply when
|
| Comment by Jeffrey Yemin [ 22/Jun/23 ] |
|
Another option: add a check as the last step of the static analysis task that fails if the tree is dirty |