[JAVA-5217] Remove getCluster method from ClusterAwareReadWriteBinding Created: 25/Oct/23 Updated: 05/Dec/23 Resolved: 07/Nov/23 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | Internal |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Jeffrey Yemin | Assignee: | Jeffrey Yemin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Documentation Changes: | Not Needed |
| Documentation Changes Summary: | 1. What would you like to communicate to the user about this feature? |
| Description |
|
After simplifying session acquisition, the ClusterAwareReadWriteBinding#getCluster method is no longer used, but we neglected to remove it. Let's remove it in order to simplify the abstraction. The interface itself has since gained a second method (getConnectionSource(ServerAddress serverAddress)), so without some further refactoring we can't just delete the entire interface. The same applies to the async version of this interface. |
| Comments |
| Comment by Githook User [ 05/Dec/23 ] |
|
Author: {'name': 'Jeff Yemin', 'email': 'jeff.yemin@mongodb.com', 'username': 'jyemin'}Message: Remove getCluster method (#1245) from the following internal interfaces:
The interfaces remain as they have picket up a second method.
|
| Comment by Githook User [ 20/Nov/23 ] |
|
Author: {'name': 'Jeff Yemin', 'email': 'jeff.yemin@mongodb.com', 'username': 'jyemin'}Message: Remove getCluster method (#1245) from the following internal interfaces:
The interfaces remain as they have picket up a second method.
|
| Comment by Tom Selander [ 30/Oct/23 ] |
|
Triage: we can potentially rename this but choosing a name that makes sense might be tricky |