[MONGOCRYPT-131] libmongocrypt: Create a config header Created: 28/Mar/19 Updated: 28/Oct/23 Resolved: 11/Jul/19 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kevin Albertson | Assignee: | Roberto Sanchez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Similar to mongoc-config.h.in in the C driver, let's create a mongocrypt-config header with macros populated during cmake configuration. Let's use that config to set which crypto provider used and whether tracing is enabled. |
| Comments |
| Comment by Githook User [ 11/Jul/19 ] |
|
Author: {'name': 'Roberto C. Sánchez', 'username': 'rcsanchez97', 'email': 'roberto@connexer.com'}Message: |
| Comment by Roberto Sanchez [ 07/Jul/19 ] |
|
kevin.albertson, I have implemented a config header, but at the moment it only contains the values for indicating which crypto provider was used. The way that libmongocrypt currently handles log tracing is based on the environment variable MONGOCRYPT_TRACE (mongocrypt-log.c, line 27). If the config header were to also contain the variable MONGOCRYPT_TRACE then the sensible way to handle this seems to be that log tracing would be set based on the value from the config header first and then possibly overridden by the environment variable MONGOCRYPT_TRACE (if it happens to be set). Does that seem right? Also, apart from the log tracing I don't see any other obvious places where the config header should be referenced. What do you think? |