[MONGOCRYPT-147] Java bindings should be tested against the .so that we actually include in the jar file Created: 18/Jul/19 Updated: 15/Jul/22 |
|
| Status: | Backlog |
| Project: | Libmongocrypt |
| Component/s: | Java binding |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Jeffrey Yemin | Assignee: | Ross Lawley |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Currently we run the Java bindings unit tests against the .so that was built for the specific platform under test. But our customers will be using a mongodb-crypt.jar containing a single libmongocrypt.so per os/architecture. We should be running the tests against the specific .so that will be included in mongodb-crypt.jar, regardless of the platform we're running the tests on. That will mean that the java build variant has to depend on the libmongocrypt build variant for whatever platform we're using for the given architecture. e.g. the rhel7 java build will depend on the ubuntu 1604 build variant for libmongocrypt. |
| Comments |
| Comment by Shane Harvey [ 11/May/20 ] |
|
The Python bindings also used to have this same problem. In https://github.com/mongodb/libmongocrypt/commit/5e22d621d5027c936f6614d99114a8cf84020ed7 I changed the Python binding unit tests to download the actual .so built by the task. |