[MONGOCRYPT-164] Store key alt names as strings instead of bson_value_t Created: 26/May/19 Updated: 13/Feb/20 Resolved: 15/Oct/19 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Albertson | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The key broker and key document stores key alt names as bson_value_t's. We cut scope to limit key alt names as strings, and we assert that these bson_value_t's are strings. But the code regarding comparing key alt names (e.g. _alt_names_equal in mongocrypt-key-broker.c) could be simplified if we store them as strings. |