[MONGOCRYPT-197] Evergreen task should create release mode dll Created: 28/Oct/19 Updated: 28/Oct/23 Resolved: 08/Nov/19 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.0-rc2 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Vincent Kam (Inactive) | Assignee: | Vincent Kam (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | fle-ga | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
After some discussion with mark.benvenuto and kevin.albertson, it appears the windows_test_build_and_upload task ((https://evergreen.mongodb.com/task_log_raw/libmongocrypt_windows_test_build_and_test_and_upload_92183bcb350ac5d60c87b89628e23e599daf435b_19_10_28_19_19_18/0?type=T#L868 ) in EG appears to be creating mongocrypt.dll in debug mode, as evidenced by the presence of the following flags: Od /Ob0 /MDd. We should probably be targeting RelWithDebugInfo |
| Comments |
| Comment by Githook User [ 08/Nov/19 ] |
|
Author: {'name': 'vincentkam', 'username': 'vincentkam', 'email': 'vincent.kam@10gen.com'}Message:
|
| Comment by Kevin Albertson [ 29/Oct/19 ] |
|
Ah, it appears that setting -DCMAKE_BUILD_TYPE=RelWithDebInfo is ignored on Windows, since cmake configures to build with multiple configurations (Debug, Release, RelWithDebInfo, MinSizeRel), and that can be specified in the build step. |