[MONGOCRYPT-213] Directory structure does not allow for bundled distribution Created: 27/Nov/19 Updated: 17/Dec/19 Resolved: 17/Dec/19 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Andreas Braun | Assignee: | Kevin Albertson |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Description |
|
For the PHP driver, we bundle libmongocrypt alongside libbson and libmongoc to allow compiling against latest bundled versions instead of (possibly outdated) system libraries. The directory structure doesn't allow for this though, as mongocrypt.h is included relatively:
Since mongocrypt.h is in stored in the src folder, the file can't be found. The directory structure should be adapted to a schema similar to libmongoc or the kms-message part of libmongocrypt, which has all its header files in a kms-message subdirectory. |
| Comments |
| Comment by Kevin Albertson [ 17/Dec/19 ] |
|
Closing as we decided not to make this change. There is a workaround for PHP. |
| Comment by Kevin Albertson [ 04/Dec/19 ] |
|
Reverting and re-opening since this broke the Go driver's inclusion of libmongocrypt. |
| Comment by Githook User [ 04/Dec/19 ] |
|
Author: {'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}Message: Revert " This reverts commit 30660c42d8676bdef7c5657c622fa6f726967d51. |
| Comment by Githook User [ 03/Dec/19 ] |
|
Author: {'email': 'kevin.albertson@mongodb.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}Message: |