[MONGOCRYPT-225] Improve and rename _mongocrypt_memcmp Created: 13/Dec/19 Updated: 28/Oct/23 Resolved: 19/Dec/19 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.1 |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Kevin Albertson | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | teserakt-audit | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The ternary comparison in the return can be improved to be closer to a constant time operation. Additionally "memcmp" is likely a misnomer, as it does not have memcmp semantics but is rather a memory equality test. |
| Comments |
| Comment by Githook User [ 19/Dec/19 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |