[MONGOCRYPT-24] Crash if sha256/hmac_sha256 hooks return error Created: 07/Aug/19  Updated: 28/Oct/23  Resolved: 07/Aug/19

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.0-beta5

Type: Bug Priority: Critical - P2
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Comments   
Comment by Githook User [ 07/Aug/19 ]

Author:

{'name': 'Kevin Albertson', 'username': 'kevinAlbs', 'email': 'kevin.albertson@10gen.com'}

Message: CDRIVER-3282 handle errors from sha256 hooks
Branch: master
https://github.com/mongodb/libmongocrypt/commit/7a793c69eff58f6bc69d605c596145a8a049fd1a

Comment by Githook User [ 07/Aug/19 ]

Author:

{'name': 'Dan Aprahamian', 'email': 'dan.aprahamian@gmail.com', 'username': 'daprahamian'}

Message: NODE: feat(cryptoCallbacks): pass crypto errors to libmongocrypt

Passes crypto errors that occur on the js side back to
libmongocrypt. Requires every cryptoCallback to return a number
on success, or an error on failure.

Also required an update to the state machine logic to account for
an error occurring during mongocrypt_ctx_finalize.

Note: errors in cryptoCallbacks sha256 and hmacSha256 will
cause a segfault until CDRIVER-3282 is fixed

Fixes NODE-2082
Branch: NODE-2082/pass-errors-back-into-libmongocrypt
https://github.com/mongodb/libmongocrypt/commit/efc853b5fc6d624166347fd63622bdd70849f21d

Comment by Githook User [ 07/Aug/19 ]

Author:

{'name': 'Dan Aprahamian', 'username': 'daprahamian', 'email': 'dan.aprahamian@gmail.com'}

Message: NODE: feat(cryptoCallbacks): pass crypto errors to libmongocrypt

Passes crypto errors that occur on the js side back to
libmongocrypt. Requires every cryptoCallback to return a number
on success, or an error on failure.

Also required an update to the state machine logic to account for
an error occurring during mongocrypt_ctx_finalize.

Note: errors in cryptoCallbacks sha256 and hmacSha256 will
cause a segfault until CDRIVER-3282 is fixed

Fixes NODE-2082
Branch: NODE-2082/pass-errors-back-into-libmongocrypt
https://github.com/mongodb/libmongocrypt/commit/2c2e828ba70a88babc8336a7cca8501f0fb89d9b

Generated at Thu Feb 08 09:07:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.