[MONGOCRYPT-254] Fix compilation warnings of duplicate symbols on MinGW Created: 22/Feb/20  Updated: 28/Oct/23  Resolved: 23/Feb/20

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.4

Type: Improvement Priority: Major - P3
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

When vendoring kms_message into libmongoc, the following warning was observed on MinGW compile:

[2020/02/19 16:38:00.709] CMakeFiles\mongoc_shared.dir/objects.a(kms_request.c.obj): In function `strndup':
[2020/02/19 16:38:00.709] C:/data/mci/4022d9d09543ecc5ea3d07d16c605eb6/mongoc/build-dir/src/kms-message/src/kms_port.h:26: multiple definition of `strndup'
[2020/02/19 16:38:00.709] CMakeFiles\mongoc_shared.dir/objects.a(kms_kv_list.c.obj):C:/data/mci/4022d9d09543ecc5ea3d07d16c605eb6/mongoc/build-dir/src/kms-message/src/kms_port.h:26: first defined here

Example patch build



 Comments   
Comment by Githook User [ 23/Feb/20 ]

Author:

{'name': 'Kevin Albertson', 'username': 'kevinAlbs', 'email': 'kevin.albertson@mongodb.com'}

Message: MONGOCRYPT-254 include string.h
Branch: master
https://github.com/mongodb/libmongocrypt/commit/efd899a33aa26346147a4aa10066a1c6df0da420

Comment by Githook User [ 23/Feb/20 ]

Author:

{'username': 'kevinAlbs', 'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com'}

Message: MONGOCRYPT-254 fixes warnings on mingw compile
Branch: master
https://github.com/mongodb/libmongocrypt/commit/83342685080ed9bc6b81f7fb2a0ffab98ad29478

Generated at Thu Feb 08 09:08:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.