[MONGOCRYPT-309] Homebrew package for libmongocrypt has extraneous pkg-config flags Created: 11/Feb/21  Updated: 08/Apr/21  Resolved: 17/Feb/21

Status: Closed
Project: Libmongocrypt
Component/s: C library
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Critical - P2
Reporter: Kevin Albertson Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CDRIVER-3906 Do not require consumers of static li... Closed

 Description   

Doing a fresh install of libmongocrypt results in extraneous flags included in libmongocrypt's package config:

$ brew install mongodb/brew/libmongocrypt
$ pkg-config --libs --cflags libmongocrypt
-DBSON_STATIC -I/usr/local/Cellar/libmongocrypt/1.2.0/include/mongocrypt -I/usr/local/Cellar/mongo-c-driver/1.17.4/include/libbson-1.0 -L/usr/local/Cellar/libmongocrypt/1.2.0/lib -L/usr/local/Cellar/mongo-c-driver/1.17.4/lib -lmongocrypt -lbson-static-1.0 /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib/libm.tbd

The following flags seem extraneous:

-DBSON_STATIC -L/usr/local/Cellar/mongo-c-driver/1.17.4/lib -lmongocrypt -lbson-static-1.0 /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib/libm.tbd

libmongocrypt statically links libbson. Consumers of libmongocrypt do not need to statically link against libbson.



 Comments   
Comment by Githook User [ 08/Apr/21 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: MONGOCRYPT-309 do not add libm on macOS (#738)
Branch: r1.17
https://github.com/mongodb/mongo-c-driver/commit/1423c223075110004ebde3796a186e31ee13bd0e

Comment by Githook User [ 23/Mar/21 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: MONGOCRYPT-309 do not add libm on macOS (#738)
Branch: csot
https://github.com/mongodb/mongo-c-driver/commit/20cada3e8550838ee68174b22164b6a3006d6436

Comment by Kevin Albertson [ 17/Feb/21 ]

Fixed with: CDRIVER-3906

Comment by Githook User [ 17/Feb/21 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: MONGOCRYPT-309 do not add libm on macOS (#738)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/20cada3e8550838ee68174b22164b6a3006d6436

Generated at Thu Feb 08 09:08:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.