[MONGOCRYPT-342] Make kms_request_t a union Created: 11/Oct/21  Updated: 25/Oct/22

Status: Backlog
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Kevin Albertson Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Background & Motivation

The kms_request_t struct has fields only applicable to certain KMS providers. The AWS specific fields are noted with comments, and the KMIP specific fields are in a separate "kmip" struct field.

Scope

  • Address the TODO comment in the definition of the struct _kms_request_t to make a union field for provider specific data.
  • Add checks to kms_request_* functions to return an error if the input kms_request_t is set to an unexpected kms_request_provider_t.

Generated at Thu Feb 08 09:08:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.