[MONGOCRYPT-383] Do not declare OpenSSL 1.1 polyfill functions in global scope Created: 16/Feb/22 Updated: 28/Oct/23 Resolved: 17/Feb/22 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Binding Changes: | Not Needed | ||||||||
| Description |
|
Note: this description is intentionally brief, as the full context for this issue is already presented in In libmongocrypt, the following OpenSSL 1.1 functions are declared when compiling against OpenSSL 1.0.x:
These functions should either be declared statically or renamed/prefixed, as is done for some libbson compat functions. Note: EVP_MD_CTX_new and EVP_MD_CTX_free are defined kms-message/src/kms_crypto_libcrypto.c, but those declarations already use static. |
| Comments |
| Comment by Githook User [ 17/Feb/22 ] |
|
Author: {'name': 'Remi Collet', 'email': 'remi@remirepo.net', 'username': 'remicollet'}Message:
They are declared in OpenSSL 1.0.1+. Co-authored-by: Kevin Albertson <kevin.albertson@mongodb.com> |
| Comment by Jeremy Mikola [ 16/Feb/22 ] |
|
remi submitted a PR: https://github.com/mongodb/libmongocrypt/pull/251 kevin.albertson: Assigning this to you for review. |