[MONGOCRYPT-388] Segregate src and test files currently in src/mlib Created: 02/Mar/22  Updated: 25/Oct/22

Status: Backlog
Project: Libmongocrypt
Component/s: None
Affects Version/s: 1.3.1
Fix Version/s: None

Type: Task Priority: Unknown
Reporter: Jeremy Mikola Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to PHPC-2031 Upgrade libmongoc to 1.21.1 and libmo... Closed

 Description   

While reviewing the diff between 1.3.0 and 1.3.1 for PHPC-2031, I came across the new src/mlib/ directory that was introduced in mongodb/libmongocrypt#243 (no related JIRA ticket that I could find).

This directory contains a mix of headers and source files, although the source files appear to just be for tests. This seems inconsistent with how code/tests are organized elsewhere in libmongoc and libmongocrypt, so I wanted to open this ticket to propose it be reorganized.

As this pertains to PHPC, this is relevant because we manually track source files and include paths for our bundled libmongoc and libmongocrypt submodules. I originally added src/mlib as a source path but later realized the path.test.c and src.test.c files have no relevance to actually using the library (and should be excluded). This isn't problematic for the time being, but if non-test source files were to be added to this directory down the line it would definitely complicate our build and packaging scripts.


Generated at Thu Feb 08 09:08:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.