[MONGOCRYPT-390] Build errors compiling PHP driver with bundled libmongocrypt 1.3.1 on Windows Created: 02/Mar/22 Updated: 28/Oct/23 Resolved: 09/Mar/22 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | 1.3.1 |
| Fix Version/s: | 1.3.2 |
| Type: | Bug | Priority: | Unknown |
| Reporter: | Jeremy Mikola | Assignee: | Colby Pike |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
I observed several build errors (see: AppVeyor task log) compiling PHPC with bundled libmongocrypt 1.3.1. An abridged log is below:
The errors in mlib/thread.h stand out, but there are also many errors/warnings due to redefined macros and symbols. It's not clear to me if the issue is caused by our build environment or libmongocrypt directly, but I'll note that previous builds of libmongocrypt 1.3.0 had no issues (see: task log). The current errors appear throughout our CI matrix, which includes VS16 (PHP 8.0+) and VS15 (PHP 7.x). |
| Comments |
| Comment by Githook User [ 18/Mar/22 ] |
|
Author: {'name': 'vector-of-bool', 'email': 'vectorofbool@gmail.com', 'username': 'vector-of-bool'}Message: No global WIN32_LEAN_AND_MEAN required. [Fix MONGOCRYPT-390] (#258) |
| Comment by Colby Pike [ 09/Mar/22 ] |
|
Fixed in https://github.com/mongodb/libmongocrypt/pull/256 and https://github.com/mongodb/libmongocrypt/pull/258 |
| Comment by Githook User [ 04/Mar/22 ] |
|
Author: {'name': 'vector-of-bool', 'email': 'vectorofbool@gmail.com', 'username': 'vector-of-bool'}Message: No global WIN32_LEAN_AND_MEAN required. [Fix MONGOCRYPT-390] (#258) |
| Comment by Jeremy Mikola [ 04/Mar/22 ] |
It turns out this wasn't feasible to address in PHPC, as defining WIN32_LEAN_AND_MEAN globally introduced other issues. Subsequent PR: https://github.com/mongodb/libmongocrypt/pull/258 |
| Comment by Jeremy Mikola [ 03/Mar/22 ] |
|
PR: https://github.com/mongodb/libmongocrypt/pull/256 Sharing some context from Slack:
The PR above will address the PINIT_ONCE_FN issue, and PHPC can sort out the other errors by defining WIN32_LEAN_AND_MEAN during compilation of bundled libmongocrypt sources. |