[MONGOCRYPT-412] Support alpha tags in GetVersion.cmake Created: 16/Mar/22  Updated: 28/Oct/23  Resolved: 17/Mar/22

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.4.0

Type: Task Priority: Unknown
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: failing-on-waterfall
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Background & Motivation
The publish-packages tasks have started failing on commits after the 1.4.0-alpha0 tagged release.

Here is an example failure

With logs:

[2022/03/13 18:26:21.607] ./curator repo --config etc/repo_config.yaml --distro debian92 --edition org --version $pkg_version --arch x86_64 --packages repo+ ./curator repo --config etc/repo_config.yaml --distro debian92 --edition org --version 1.4.0alpha0+20220313gita088ed891d --arch x86_64 --packages repo
[2022/03/13 18:26:21.626] [curator] 2022/03/13 18:26:21 [p=info]: curator version: e0b5f66fc89ec0acddcd40ea5f447a8300ded2b9
[2022/03/13 18:26:21.627] [curator] 2022/03/13 18:26:21 [p=emergency]: problem constructing task for building repository: creating initial version: error parsing '1.4.0alpha0+20220313gita088ed891d': Invalid character(s) found in patch number "0alpha0"
[2022/03/13 18:26:21.629] Command failed: command encountered problem: error waiting on process '411a7e9f-ac20-4a01-9ce2-9407a1bd5d11': exit status 1

This appears to be caused by the GetVersion.cmake script not including the dash. For example, if checked out to a088ed891d89381c9b1427344dca13616f9884f3, GetVersion.cmake reports the following:

$ cmake -P ./cmake/GetVersion.cmake
1.4.0alpha0+20220316gita088ed891d

Scope

  • Update GetVersion.cmake to match "alpha" as a prerelease part.
  • Update release instructions to note that valid prereleases can only have "alpha", "beta", or "rc" as a prerelease part.


 Comments   
Comment by Githook User [ 17/Mar/22 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: MONGOCRYPT-412 parse alpha tags in GetVersion.cmake (#267)
Branch: master
https://github.com/mongodb/libmongocrypt/commit/934e59e6666fc9ba4be31da8f87d135e7283b024

Generated at Thu Feb 08 09:08:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.