[MONGOCRYPT-488] Context may not enter MONGOCRYPT_CTX_ERROR on KMS provider validation errors Created: 13/Oct/22  Updated: 28/Oct/23  Resolved: 16/Oct/22

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.6.2

Type: Bug Priority: Major - P3
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Scope

  • Update error returns in mongocrypt_ctx_provide_kms_providers to set the ctx->state to MONGOCRYPT_CTX_ERROR

Background & Motivation
An error in a context function is expected to set the state of the context as MONGOCRYPT_CTX_ERROR. Some drivers require this behavior for correctness. For example, the Node.JS bindings do not always check the return values of some mongocrypt_ctx_* functions, and may rely on the context state to return an error.



 Comments   
Comment by Githook User [ 16/Oct/22 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: MONGOCRYPT-488 set context error state in provide_kms_providers (#475)
Branch: r1.6
https://github.com/mongodb/libmongocrypt/commit/406a0b0a8b65c09f897f5f1b30a7422cf15298ef

Comment by Githook User [ 16/Oct/22 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}

Message: MONGOCRYPT-488 set context error state in provide_kms_providers (#475)
Branch: master
https://github.com/mongodb/libmongocrypt/commit/ba45dac26063574211e648f3db986529436b5eac

Generated at Thu Feb 08 09:08:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.