[MONGOCRYPT-517] Update Intel DFP dependency to support build without network access Created: 19/Jan/23  Updated: 28/Oct/23  Resolved: 26/Jan/23

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.7.1

Type: Improvement Priority: Unknown
Reporter: Roberto Sanchez Assignee: Roberto Sanchez
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by MONGOCRYPT-523 Unable to build offline Closed

 Description   

The decimal128 support implemented in MONGOCRYPT-483 introduced a dependency on Intel DFP. The initial implementation downloads the Intel DFP library source distribution from the Internet for each build. it is necessary to support disconnected builds (i.e., builds without network access), which entails the following improvements:

  • include the the Intel DFP sources as a vendored third-party module of libmongocrypt (similar to how zlib is handled for the C driver)
  • add the option for the user to build using a system-installed Intel DFP library rather than using the vendored Intel DFP sources


 Comments   
Comment by Githook User [ 26/Jan/23 ]

Author:

{'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}

Message: MONGOCRYPT-517 vendor Intel DFP code and also allow using system DFP
Branch: r1.7
https://github.com/mongodb/libmongocrypt/commit/2b86a3f1e55c3dd55d16f0dc94432dab0a0d2faf

Comment by Githook User [ 26/Jan/23 ]

Author:

{'name': 'Roberto C. Sánchez', 'email': 'roberto@connexer.com', 'username': 'rcsanchez97'}

Message: MONGOCRYPT-517 vendor Intel DFP code and also allow using system DFP
Branch: master
https://github.com/mongodb/libmongocrypt/commit/f5b10e98e03b285df6539feca8d13221d0808be8

Comment by Roberto Sanchez [ 26/Jan/23 ]

https://github.com/mongodb/libmongocrypt/pull/550

Comment by Githook User [ 25/Jan/23 ]

Author:

{'name': 'vector-of-bool', 'email': 'vectorofbool@gmail.com', 'username': 'vector-of-bool'}

Message: MONGOCRYPT-517 Reuse the proper DFP names from bid_conf.h (#534)

This will ensure that we get the proper function references, regardless
of where DFP comes from.
Branch: shreyaskalyan/MONGOCRYPT-509
https://github.com/mongodb/libmongocrypt/commit/2c2d78eb0581faccf4a04f5a8873521a8798d81b

Comment by Githook User [ 20/Jan/23 ]

Author:

{'name': 'vector-of-bool', 'email': 'vectorofbool@gmail.com', 'username': 'vector-of-bool'}

Message: MONGOCRYPT-517 Reuse the proper DFP names from bid_conf.h (#534)

This will ensure that we get the proper function references, regardless
of where DFP comes from.
Branch: master
https://github.com/mongodb/libmongocrypt/commit/2c2d78eb0581faccf4a04f5a8873521a8798d81b

Generated at Thu Feb 08 09:08:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.