[MONGOCRYPT-553] Do not attach QE delete tokens when v2 is enabled Created: 09/Mar/23  Updated: 28/Oct/23  Resolved: 20/Mar/23

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.8.0, 1.8.0-alpha0

Type: Task Priority: Major - P3
Reporter: Erwin Pe Assignee: Shreyas Kalyan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: PM-2972
Binding Changes: Not Needed

 Description   

In mongocrypt_ctx_encrypt.c:_fle2_finalize(), the part that calls command_needs_deleteTokens() and generate_delete_tokens() must be skipped entirely if QEv2 is enabled.



 Comments   
Comment by Githook User [ 20/Mar/23 ]

Author:

{'name': 'Shreyas Kalyan', 'email': '35750327+shreyaskalyan@users.noreply.github.com', 'username': 'shreyaskalyan'}

Message: MONGOCRYPT-553 Do not attach QE delete tokens when v2 is enabled (#598)

---------

Co-authored-by: Shreyas Kalyan <shreyas.kalyan@mongodb.com>
Branch: shreyaskalyan/MONGOCRYPT-539
https://github.com/mongodb/libmongocrypt/commit/fa213b62bc403aa963e01d30b66ac0b0ec25e5cf

Comment by Githook User [ 20/Mar/23 ]

Author:

{'name': 'Shreyas Kalyan', 'email': '35750327+shreyaskalyan@users.noreply.github.com', 'username': 'shreyaskalyan'}

Message: MONGOCRYPT-553 Do not attach QE delete tokens when v2 is enabled (#598)

---------

Co-authored-by: Shreyas Kalyan <shreyas.kalyan@mongodb.com>
Branch: master
https://github.com/mongodb/libmongocrypt/commit/fa213b62bc403aa963e01d30b66ac0b0ec25e5cf

Comment by Githook User [ 20/Mar/23 ]

Author:

{'name': 'Shreyas Kalyan', 'email': 'shreyas.kalyan@mongodb.com', 'username': 'shreyaskal'}

Message: MONGOCRYPT-553 Lint
Branch: shreyaskalyan/MONGOCRYPT-553
https://github.com/mongodb/libmongocrypt/commit/3850775c52074e9d95b7ad4fb4c550ce8269a455

Comment by Githook User [ 20/Mar/23 ]

Author:

{'name': 'Shreyas Kalyan', 'email': 'shreyas.kalyan@mongodb.com', 'username': 'shreyaskal'}

Message: MONGOCRYPT-553 Addressed Kevin and Erwin's comments PS1
Branch: shreyaskalyan/MONGOCRYPT-553
https://github.com/mongodb/libmongocrypt/commit/4297ef0f4b35006a406aea62a1988567d13fb918

Comment by Githook User [ 16/Mar/23 ]

Author:

{'name': 'Shreyas Kalyan', 'email': 'shreyas.kalyan@mongodb.com', 'username': 'shreyaskal'}

Message: MONGOCRYPT-553 Do not attach QE delete tokens when v2 is enabled
Branch: shreyaskalyan/MONGOCRYPT-553
https://github.com/mongodb/libmongocrypt/commit/bcc222e4e63f009074ca0302c4bb76d43ce22bc8

Generated at Thu Feb 08 09:08:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.