[MONGOCRYPT-571] IntelDFP build error on macOS 13.3.1 Ventura Created: 14/Apr/23  Updated: 28/Oct/23  Resolved: 17/Apr/23

Status: Closed
Project: Libmongocrypt
Component/s: None
Affects Version/s: None
Fix Version/s: 1.7.4

Type: Build Failure Priority: Major - P3
Reporter: Kevin Albertson Assignee: Kyle Kloberdanz
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Binding Changes: Not Needed

 Description   

A build error was reported in slack. Here are the full build logs. Here is the error:

cd /tmp/libmongocrypt-20230414-327-1xvowtd/libmongocrypt-1.7.3/kms-message && /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang -DKMS_MESSAGE_ENABLE_CRYPTO -DKMS_MESSAGE_ENABLE_CRYPTO_COMMON_CRYPTO -DKMS_MESSAGE_LITTLE_ENDIAN  -O3 -DNDEBUG -std=gnu90 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.sdk -fvisibility=hidden -Werror=implicit -Werror=return-type -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=ignored-qualifiers -Werror=uninitialized -MD -MT kms-message/CMakeFiles/kms_message_obj.dir/src/kms_b64.c.o -MF CMakeFiles/kms_message_obj.dir/src/kms_b64.c.o.d -o CMakeFiles/kms_message_obj.dir/src/kms_b64.c.o -c /tmp/libmongocrypt-20230414-327-1xvowtd/libmongocrypt-1.7.3/kms-message/src/kms_b64.c
/tmp/libmongocrypt-20230414-327-1xvowtd/libmongocrypt-1.7.3/_deps/intel_dfp-src/LIBRARY/float128/dpml_exception.c:186:13: error: call to undeclared function 'raise'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            DPML_SIGNAL(p);
            ^
/tmp/libmongocrypt-20230414-327-1xvowtd/libmongocrypt-1.7.3/_deps/intel_dfp-src/LIBRARY/float128/dpml_exception.c:135:28: note: expanded from macro 'DPML_SIGNAL'
#   define DPML_SIGNAL(p)        raise(SIGFPE)
                                 ^
1 error generated.



 Comments   
Comment by Githook User [ 17/Apr/23 ]

Author:

{'name': 'Kyle Kloberdanz', 'email': 'kyle.kloberdanz@mongodb.com', 'username': 'kkloberdanz'}

Message: Fix build for MacOS Ventura (#619)

MONGOCRYPT-571

Fix build for MacOS Ventura
Patch missing headers for Intel DFP
Branch: r1.7
https://github.com/mongodb/libmongocrypt/commit/6d03b10e645127756eab5e08486acacb769e896a

Comment by Githook User [ 14/Apr/23 ]

Author:

{'name': 'Kyle Kloberdanz', 'email': 'kyle.kloberdanz@mongodb.com', 'username': 'kkloberdanz'}

Message: Fix build for MacOS Ventura (#619)

MONGOCRYPT-571

Fix build for MacOS Ventura
Patch missing headers for Intel DFP
Branch: master
https://github.com/mongodb/libmongocrypt/commit/5e322e26be22cd87754212fa1a78b412e061e793

Generated at Thu Feb 08 09:08:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.