[MONGOCRYPT-71] Test kms-message on evergreen Created: 07/Mar/19 Updated: 28/Oct/23 Resolved: 02/May/19 |
|
| Status: | Closed |
| Project: | Libmongocrypt |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kevin Albertson | Assignee: | Roberto Sanchez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | Build libmongocrypt library |
| Description |
|
We have a project (https://evergreen.mongodb.com/waterfall/kms_message) but no config. We should build and run the tests in an evergreen task. |
| Comments |
| Comment by Roberto Sanchez [ 06/Apr/19 ] |
|
Also, it appears that I do not have project admin access to either kms-message or libmongocrypt in Evergreen. I think I might need that, but I am not sure. If you agree, could you set me up with it? Or if I have to create a ticket, just let me know where it goes. |
| Comment by Kevin Albertson [ 06/Apr/19 ] |
|
Ah true, it's an upstream evergreen project, not git repo. So we still need a separate kms-message project. But I agree it seems worthwhile to configure libmongocrypt project to depend on kms-message project. |
| Comment by Roberto Sanchez [ 06/Apr/19 ] |
|
kevin.albertson after looking at the Evergreen documentation link, I am not certain that it would save us any effort. We still need to create an Evergreen configuration for kms-message and it will need to run its own tasks. The way I read the inter-project dependency documentation, it looks like you can set it so that a task completion in the upstream project triggers a build in the downstream project. I do not think that it is possible to make it so that a commit pushed to the kms-message Git repository would kick off a libmongocrypt build. That said, I think there is utility in making kms-message builds also trigger libmongocrypt builds, as that would let you know if a change in kms-message has broken something in libmongocrypt. |
| Comment by Roberto Sanchez [ 02/Apr/19 ] |
|
Thanks for the pointer. I'll take a look at it. |
| Comment by Kevin Albertson [ 02/Apr/19 ] |
|
Something I recently learned that may be helpful is using an interproject dependency instead of having a separate evergreen project for kms-message: We're already compiling kms-message as part of libmongocrypt's evergreen configuration. Perhaps it's just simpler to run the kms-message test runner in addition to libmongocrypt's test runner, and have the libmongocrypt evergreen proejct have an inter project dependency on kms-message. |