[PYTHON-136] Make master_slave_connection less of a special case Created: 21/Jun/10  Updated: 07/Dec/11  Resolved: 02/Nov/11

Status: Closed
Project: Python Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 2.1

Type: Improvement Priority: Major - P3
Reporter: Michael Dirolf Assignee: Bernie Hackett
Resolution: Fixed Votes: 0
Labels: None

# Replies: 4
Participants:
Days since reply: 6 years, 38 weeks ago
Date of 1st Reply:
Last commenter: Rathi Gnanasekaran
Last comment by Customer: false

 Description   

should be easier for others to implement similar things on their own, and better integration will avoid some of the issues that pop up w/ this now and again.



 Comments   
Comment by Eytan Daniyalzade [ 14/Mar/11 ]

Could you please provide more information on this bug? pymongo master_slave_connection.py has references to this bug in multiple places, e.g. tz_info being hardcoded to true, so i am wondering how this bug relates to that.

Comment by Bernie Hackett [ 14/Mar/11 ]

Mike Dirolf no longer works for 10gen but I think what he probably meant was that the master_slave_connection shouldn't even be necessary. We currently promote the use of replica sets, not master/slave setups. The Connection class doesn't currently support the distributed reads provided by master_slave_connection but it should.

How this all relates to tz_aware I don't know. tz_aware is a setting of the Connection instances the MasterSlaveConnection instance is created with. I suspect that property was added because it exists in Connection as well. tz_aware=True was once the default when you instantiate Connection, but that is no longer true. It should probably be hard coded to False in MasterSlaveConnection instead.

Comment by auto [ 02/Nov/11 ]

Author:

{u'login': u'behackett', u'name': u'behackett', u'email': u'bernie@10gen.com'}

Message: MasterSlaveConnection.document_class PYTHON-136

Document class is now configurable as in Connection
and ReplicaSetConnection.
Branch: master
https://github.com/mongodb/mongo-python-driver/commit/020318251939bf2a37e691817dbd02d146e7d01e

Comment by Bernie Hackett [ 02/Nov/11 ]

tz_aware was made configurable for PYTHON-279

Generated at Thu Jul 19 12:06:25 UTC 2018 using JIRA 7.8.2#78002-sha1:944b71ecbe2e09c23503821098ef280c785b44a8.