[SERVER-10017] Remove "run repair" recommendation from error messages Created: 25/Jun/13 Updated: 27/Oct/15 Resolved: 20/Dec/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Logging |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.5 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Ian Daniel | Assignee: | Matt Kangas |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
Some server error messages contain recommendations to run repair, or to consider running repair. We should remove these recommendations to run repair. A repair removes inconsistent/corrupt data. Depending on the cause of the problem and the user's configuration, there may be better ways of recovering from the problem than by running repair. For example, in some cases, it might be possible to re-sync from another node in a replica set. src/mongo/db/database.cpp contains two massert messages that recommend running repair:
src/mongo/db/btree.cpp and src/mongo/db/pdfile.cpp contain recommendations to consider running repair:
(There might be other occurrences of similar messages.) Even suggesting "consider repairing database" seems sub-optimal. If we need to make a recommendation, we should point to documentation that describes options when a database looks corrupt. e.g. syncing from a known good node. |
| Comments |
| Comment by Matt Kangas [ 20/Dec/13 ] |
|
Progress on docs proceeding in |
| Comment by Githook User [ 20/Dec/13 ] |
|
Author: {u'username': u'kangas', u'name': u'Matt Kangas', u'email': u'matt.kangas@mongodb.com'}Message: "repair" is rarely the best course of action in a data loss scenario, |
| Comment by Ian Daniel [ 04/Sep/13 ] |
|
Hi Matt, I think we could use the page that Sam suggests, but I believe it would need some changes. I have outlined the changes in Kind regards, |
| Comment by Matt Kangas [ 30/Aug/13 ] |
|
jantje.daniel - please confirm that the URL Sam mentioned above is sufficient for the purposes of this ticket. (e.g. the log messages in question) |
| Comment by Sam Kleinman (Inactive) [ 29/Aug/13 ] |
|
I think the relevant document exists already at: http://docs.mongodb.org/manual/tutorial/recover-data-following-unexpected-shutdown/ You can include the following dochub url http://dochub.mongodb.org/core/data-recovery in the server code base. |