[SERVER-10165] Change aggregate shell helper to return cursor. Created: 10/Jul/13 Updated: 22/Nov/13 Resolved: 08/Oct/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework, Shell |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Major Change | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
If connected to a server that doesn't support agg cursors, fallback to non-cursor form and return a simulated cursor. Most of the work here will involve updating the tests to work with the new API. |
| Comments |
| Comment by auto [ 08/Oct/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: The actual change is in src/mongo/shell/collection.js with the remaining changes The "ideal" arguments are now an array of pipeline ops and an optional object . For |
| Comment by Daniel Pasette (Inactive) [ 17/Sep/13 ] |
|
I think we should make a hard break of backwards compatibility here. 2.6+ will always return a cursor. If you want to use a 2.6+ shell without a cursor, the workaround is to not use the helper in the shell and not pass the cursor. Currently for the jstests that use the aggregate helper, it calls the cursor and non-cursor forms and asserts that the return values are the same. For cursor specific tests, we use the explicit command form and pass the "cursor" param. |
| Comment by auto [ 11/Jul/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: related tickets: |