[SERVER-10235] ProgressMeter for closeAllFiles uses arguments incorrectly Created: 17/Jul/13  Updated: 11/Jul/16  Resolved: 29/Aug/13

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 2.4.5
Fix Version/s: 2.5.3

Type: Bug Priority: Trivial - P5
Reporter: Tad Marshall Assignee: Matt Kangas
Resolution: Done Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

The constructor for ProgressMeter takes two optional string parameters: "units" and "name". "name" is used as the prefix for logged progress reports (default is "Progress") and "units" is displayed in parentheses following the progress percentage if non-empty.

The constructor for ProgressMeter in MongoFile::closeAllFiles() (mmap.cpp) passes "File Closing Progress" in the "units" argument instead of a more appropriate "files" and does not pass an argument for "name".

        ProgressMeter pm(mmfiles.size(), 2, 1, "File Closing Progress");

should be

        ProgressMeter pm(mmfiles.size(), 2, 1, "files", "File Closing Progress");



 Comments   
Comment by Matt Kangas [ 29/Aug/13 ]

Merged in https://github.com/mongodb/mongo/commit/4b6fcde3430ef3ce527ebdb628bcb99696a7b194

Fixed a bug where the default Progress Meter name was unintentionally being used in mmap shutdown

Comment by Eric Daniels (Inactive) [ 23/Jul/13 ]

Pull Request:
https://github.com/mongodb/mongo/pull/460

Generated at Thu Feb 08 03:22:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.