[SERVER-10727] Cleanup TTL internals Created: 10/Sep/13  Updated: 13/Aug/16  Resolved: 02/Aug/16

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.3.11

Type: Task Priority: Minor - P4
Reporter: Scott Hernandez (Inactive) Assignee: Kevin Albertson
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-9184 Cleanup TTL logic/locking Closed
is related to SERVER-11732 TTL indexes should imply usePowersOf2... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   
  • Remove TTL prefix from log lines
  • Include namespace for log line with query
  • return early if not isMaster (where it is defined in doTTLForDB)


 Comments   
Comment by Githook User [ 02/Aug/16 ]

Author:

{u'username': u'kevinAlbs', u'name': u'Kevin Albertson', u'email': u'kevin.albertson@10gen.com'}

Message: SERVER-10727 Clean TTL log lines and comments
Branch: master
https://github.com/mongodb/mongo/commit/81185a50aeed5b2beed2c0a81b381a482489fdb7

Comment by Kevin Albertson [ 28/Jul/16 ]

The namespace is now included in the log line: https://github.com/mongodb/mongo/blob/v3.2.3/src/mongo/db/ttl.cpp#L225

I believe TTL deletion should still occur for collections that are writable in a secondary/slave (i.e. in the local database), which it currently does. It would make sense to skip over a non-writable database, but due to SERVER-24631 we now only iterate over collections with a TTL index, and do not group iterations by database.

Comment by Ian Whalen (Inactive) [ 25/Jul/16 ]

CC kevin.albertson to see if this is something he can do quickly since he's already in the TTL code at the moment.

Generated at Thu Feb 08 03:23:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.