[SERVER-10823] isMaster does not contain tags in some cases Created: 19/Sep/13  Updated: 11/Jul/16  Resolved: 30/Sep/13

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: 2.5.2
Fix Version/s: 2.5.3

Type: Bug Priority: Major - P3
Reporter: Randolph Tan Assignee: Matt Dannenberg
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File tags.js    
Issue Links:
Depends
is depended on by SERVER-10383 read_pref_cmd.js failed on Windows 64... Closed
Related
related to SERVER-6376 Tag replica set nodes without electio... Closed
is related to SERVER-10945 isMaster can return duplicate hosts Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

Attached test. Observation based on test:

1. If replSetReconfig contains

{ priority: 0 }

, test passes.
2. In the failure case, the primary does not relinquish it's primary status.
3. Test runs fine in 2.4.6 & 2.5.2.



 Comments   
Comment by auto [ 30/Sep/13 ]

Author:

{u'username': u'dannenberg', u'name': u'Matt Dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-10823 fix buildbot breakage

setOtherPrimary() asserts that we are not the primary
msgCheckState() was making sure the node isn't primary before calling setOtherPrimary()
but it was comparing members instead of just member ids
due to recent changes to reconfig (by which, a reconfig may not reset all connections and cause an election on tag changes), there is a race condition with the members
but the member id should be consistant and safe
Branch: master
https://github.com/mongodb/mongo/commit/043238005510c70d2d59a6228c58f0f44685d143

Comment by auto [ 24/Sep/13 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-10823 update member configs properly on tags-only reconfigs

fixes problems caused by SERVER-6376
Branch: master
https://github.com/mongodb/mongo/commit/0be5ade7cdccccaef2f11b31819fd671c7476c71

Comment by Matt Dannenberg [ 20/Sep/13 ]

This is my fault (caused by how I fixed SERVER-6376). I am working on a fix.

Generated at Thu Feb 08 03:24:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.