[SERVER-11178] Create IndexCatalog and remove CatalogHacks Created: 14/Oct/13  Updated: 27/Sep/16  Resolved: 13/Dec/13

Status: Closed
Project: Core Server
Component/s: Index Maintenance
Affects Version/s: None
Fix Version/s: 2.5.5

Type: Improvement Priority: Major - P3
Reporter: Eliot Horowitz (Inactive) Assignee: Eliot Horowitz (Inactive)
Resolution: Done Votes: 0
Labels: buildbot
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-14342 Shard crashes on split operation if c... Closed
Related
related to SERVER-26335 Initial sync with buildIndexes=false ... Closed
related to DOCS-2465 Comprehensive document about backward... Closed
Backwards Compatibility: Major Change
Participants:

 Description   

This will live under Collection, and hand out IndexDescriptors and IndexAccessMethods



 Comments   
Comment by Githook User [ 13/Dec/13 ]

Author:

{u'username': u'hkhalsa', u'name': u'Hari Khalsa', u'email': u'hkhalsa@10gen.com'}

Message: SERVER-11178 remove catalog hack
Branch: master
https://github.com/mongodb/mongo/commit/3769b3046df920d5e323a0c18475f5e0d4c891af

Comment by Githook User [ 18/Nov/13 ]

Author:

{u'username': u'monkey101', u'name': u'Dan Pasette', u'email': u'dan@10gen.com'}

Message: SERVER-11178: Adjust two log levels in new catalog code
Branch: master
https://github.com/mongodb/mongo/commit/4461f5cb37fbd1f5f4b6c9bf2d78e442a94f805c

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: use IndexCatalog for creating indexes during migration, more cleanup
Branch: master
https://github.com/mongodb/mongo/commit/fe3eabdf8126f975594048b3df33ec023af70cb9

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: some style fixes on new IndexCatalog hook up to migration
Branch: master
https://github.com/mongodb/mongo/commit/25aad028837244924cb32a30b214d209018b50e5

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: remove dead precalced code
Branch: master
https://github.com/mongodb/mongo/commit/ba752b46d1cce09b1462580639459743cc56bfe8

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: use IndexCatalog for creating indexes during migration
Branch: master
https://github.com/mongodb/mongo/commit/573560edeb1bced0bd9d3202d93a986dd5d6344c

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: use IndexCatalog to check for _id indexes
Branch: master
https://github.com/mongodb/mongo/commit/9d9598668bbcf658b257b4d5e858e286be4148f1

Comment by Eliot Horowitz (Inactive) [ 06/Nov/13 ]

This is done except for files that should be going away shortly.
Once that is done, we'll remove the actual cataloghack file

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: move reindex to use IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/6d8c36fa3343b3bf9308357d7194bebff2f59ad1

Comment by auto [ 06/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: Collection::insertDocument should not create a new error code for dup key errors
Branch: master
https://github.com/mongodb/mongo/commit/6611642ebe93a72fad82ebd65e0d52cf4f41c170

Comment by auto [ 03/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: fix 32bit and osx compile numeric cast
Branch: master
https://github.com/mongodb/mongo/commit/83e056702108e7693e58886a8364aaa036eb6edd

Comment by auto [ 02/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: index building now all with IndexCatalog, CatalogHack out of all new paths
Branch: master
https://github.com/mongodb/mongo/commit/ac7b0f59ee5ee58a27d1927047426a2d0d354e4e

Comment by auto [ 02/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: IndexScan now uses IndexCatalog classes
Branch: master
https://github.com/mongodb/mongo/commit/f4752b153a3294bd6dfbfb3b626526c7baf7f90e

Comment by auto [ 02/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: IndexLegacy::getMissingField using IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/c83e2593e8ad68bd2ad09eaaa4e28df34d0da068

Comment by auto [ 02/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: IndexLegacy partly to IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/8bc2fd8c35414b99017068e68c505a2a1b14a2b2

Comment by auto [ 02/Nov/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: more IndexCatalog work
Branch: master
https://github.com/mongodb/mongo/commit/8f73459ac4c750f9aaa957ec2c6e6569df43d8e4

Comment by auto [ 29/Oct/13 ]

Author:

{u'username': u'monkey101', u'name': u'Dan Pasette', u'email': u'dan@10gen.com'}

Message: SERVER-11178: re-added nIndexesWas to reIndex result
Branch: master
https://github.com/mongodb/mongo/commit/1361ad0eacf7b924226d71aaab12e6f62e76e476

Comment by auto [ 29/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: bg indexing a lot faster now, need more things to index
Branch: master
https://github.com/mongodb/mongo/commit/451d6babfd1801b8bbfd746b1586c541acb078ee

Comment by auto [ 29/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: remove more CatalogHack uses for IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/a154dfd0c61129d154e0eb3782b4f4110ce150f1

Comment by auto [ 28/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: increase time to create background index since its faster now
Branch: master
https://github.com/mongodb/mongo/commit/7844d0500166db2ebb49d866bdd2d2f2af8c3b09

Comment by auto [ 28/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: simplify and correct cache when background index finishes
Branch: master
https://github.com/mongodb/mongo/commit/0ca21679b816a8ca55da8b619d50e0edde477a62

Comment by auto [ 28/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: prep to make IndexDetails hidden behind IndexCatalog and IndexDescriptor
Branch: master
https://github.com/mongodb/mongo/commit/7e452de2877845b27c0c1205b99d2057998da810

Comment by auto [ 28/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: fix caching of IndexDescriptors with drop
Branch: master
https://github.com/mongodb/mongo/commit/ed9e214360ce91c07adf41aa6071c402baaa8dda

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: fix ownership of IndexDescriptor for FTS
Branch: master
https://github.com/mongodb/mongo/commit/d8ca8b5faa1447365403cfb8da16a041e7d31d95

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: take access methods from cache when possible
Branch: master
https://github.com/mongodb/mongo/commit/d23caedc07564b6ea05ad0b96fa6e6f57a5b1260

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: fix drop_dups with index create by putting back logOp after changing delete path
Branch: master
https://github.com/mongodb/mongo/commit/2d32e99f5e67243f41e91c5d142b2a735e22d46a

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: more geo queries to IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/a348801dd5640b0c2cae22f5e3f8017bf5d68465

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: geo queries to IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/d6881313aea5957fdbf12e0b983a9eafb4182283

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: geo haystack to IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/74392743f7df0ae1abb820549b8c4b802e260cc9

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: remove impossible to reach code
Branch: master
https://github.com/mongodb/mongo/commit/23fd1682cba522fae1cf9c108244d7f4a22b2179

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: prefecth CatalogHack -> IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/1c6132d444d3c19a168e7e943d5595df08cfb477

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: more CatalogHack -> IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/98133b76bec6d2b1bcec5329af461bc8b0c14725

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: new find driver from CatalogHack -> IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/d47828fa73dd7930c7b200c2a2ab594ac539a5d6

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: move validate to IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/4042dab63468646b5efd6459e897eb241a589f24

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: minor validate cleanup prep
Branch: master
https://github.com/mongodb/mongo/commit/ef4cb38c07a72f70e703f8949cbe87e9267227e4

Comment by auto [ 26/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: move validate command to its own file
Branch: master
https://github.com/mongodb/mongo/commit/60e9928620dbb71aea8bd195456e4247beb3989c

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: Collection::insertDocument doesn't work with _id, that should be above
Branch: master
https://github.com/mongodb/mongo/commit/62785e188f42bba661c1f108e70a92aef29c0e92

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: remove unused variable from old index_update
Branch: master
https://github.com/mongodb/mongo/commit/f95946f6908447dd1b27e5537f3a5ef5d1df723d

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: move more CatalogHack calls to IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/715e6a89e1db69d695588962dc5c9d35c699d1e8

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: refactor index_create to not use Cataloghack
Branch: master
https://github.com/mongodb/mongo/commit/27900becdf3bbeda9414ffeb03d0dcb465206ba6

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: rename index_update. to catalog/index_create.
Branch: master
https://github.com/mongodb/mongo/commit/6aadb9dcb12c21e7ec4d5665f52cc6e18d87a2ae

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: remove index_update.h from places its not needed (most)
Branch: master
https://github.com/mongodb/mongo/commit/46d8af46ac3c734d4e87c6da9a36f5517d14c8a4

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: move ensureHaveIdIndex from bare to inside IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/bb597087d1d8aa4c0aecb34bd37ca60588dd61aa

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: remove prepareToBuildIndex, and have pdfile call into IndexCatalog for creating indexes
Branch: master
https://github.com/mongodb/mongo/commit/dedd6bfea9b15e1e10de5cb67216f89ecb36fea8

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: move _id key fixing into IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/17397f441842a66a271ed6490c92d8eb56545e5e

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: moving all index creation logic into IndexCatalog
Branch: master
https://github.com/mongodb/mongo/commit/e01542ba7a9e069214540ab7be92a21badd9bf44

Comment by auto [ 25/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: first cut at IndexCatalog::createIndex
Branch: master
https://github.com/mongodb/mongo/commit/bf2b4ee2ead2fabcb2e3263b30903cd12e8ee9ac

Comment by Eliot Horowitz (Inactive) [ 25/Oct/13 ]

Grep for things left to do:

git grep CatalogHack:: | grep -v src/mongo/db/btreecursor.cpp | grep -v src/mongo/db/query_optimizer_internal.cpp | grep -v src/mongo/db/query_plan.cpp | grep -v src/mongo/db/index/2d_index_cursor.cpp | grep -v src/mongo/db/index_selection.cpp

Also, a grep for IndexDescriptor with _ptr would be a good check after for safety.

Comment by auto [ 23/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: fix index rebuilding after crash
Branch: master
https://github.com/mongodb/mongo/commit/2bc327964e59cfc7d2a0a5241df04d56b5a039a3

Comment by auto [ 23/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: fix validate for new extent semantics
Branch: master
https://github.com/mongodb/mongo/commit/667ea0bdbd3ec255820f9318383d4ae6c7c10a59

Comment by auto [ 23/Oct/13 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-11178: Introduce IndexCatalog and requirements
IndexCatalog will be the only place to get information about indexes, and modify them
still a lot of work left, but a lot of the logic is now shifted
Branch: master
https://github.com/mongodb/mongo/commit/a942dd1d88c1c6dddb68f85a02f72434c2999f9e

Generated at Thu Feb 08 03:25:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.