[SERVER-1150] Mongod.ese --remove hangs and lacks output on Windows 7 Created: 25/May/10  Updated: 12/Jul/16  Resolved: 03/Jun/10

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 1.4.3
Fix Version/s: 1.4.4, 1.5.3

Type: Bug Priority: Minor - P4
Reporter: Justin Dearing Assignee: Eliot Horowitz (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 7


Participants:

 Description   

I was attempting to upgrade from mongo 1.42 to mongo 1.43 on Windows 7. I downloaded the binaries and installed them to a new folder, different from the existing 1.42 install. I then edited my path and opened up a new command prompt. I typed in mongod --remove and it hung for over a minute. The service stopped according to the event viewer but did not shut down. After waiting over a minute I hit ctrl+c and tried the command again and it worked. I'd like to see the following:

1. Some console error messages. Specifically:

Service "Mongo DB" is running attempting to stop now . . . OR Service "Mongo DB" is not running OR Service "Mongo DB" is disabled
Then
Service "Mongo DB" stopped successfully . . .
Then
Removing service "Mongo DB"
Then
Service "Mongo DB" removed successfully.

2. If the hanging can be reproduced I'd like to see it eliminated.



 Comments   
Comment by Justin Dearing [ 03/Jun/10 ]

Can this be backported to 1.4.3 as well since its a bug.

Comment by Justin Dearing [ 03/Jun/10 ]

Fix in v1.4 http://github.com/zippy1981/mongo/commit/1e789f844c3b4cea6f0a5b2f7f527af4f05ddbaa

Fix in master http://github.com/zippy1981/mongo/commit/240f44e620c846f1112055aac7e7a27b67fb9859

Sorry that the merges will not be clean.

Comment by Justin Dearing [ 02/Jun/10 ]

Ok my git branch is a mess now, I will fix that in the morning and submit a proper commit to cherry-pick. However, the change was a missing break statement:

while ( ::QueryServiceStatus( schService, &serviceStatus ) ) {
if ( serviceStatus.dwCurrentState == SERVICE_STOP_PENDING )

{ Sleep( 1000 ); }

else

{ break; }

}

Comment by Eliot Horowitz (Inactive) [ 27/May/10 ]

We'll backport all bugs if the bug fix itself isn't risky.
So once we figure out the issue, we'll determine if it makes sense to backport.
Hard to know if we can until we find the problem.

Comment by Justin Dearing [ 27/May/10 ]

I think targeting this fix for 1.4.4 is warranted. This is an outright bug, and fixing it would be quick and low risk. OTOH, a minor problem uninstalling mongo as a service is hardly a mission critical type of problem.

Are there some written guidelines as to what goes in the stable branch versus what just goes into the dev branch?

Comment by Justin Dearing [ 25/May/10 ]

Reproduced exactly the same on a Windows 2008 server.

In both cases the services have been up for days. The server has been up for a while. In neither case is the mongo instance being hit all that much (and not at all while I am issuing the stop command).

Generated at Thu Feb 08 02:56:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.