[SERVER-11692] Change Variables implementation in agg to not use string lookup at runtime. Created: 14/Nov/13 Updated: 11/Jul/16 Resolved: 14/Nov/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Participants: |
| Comments |
| Comment by Githook User [ 14/Nov/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: This is what the past 3 commits have been building up to. Variable names are now "compiled away" and |
| Comment by Githook User [ 14/Nov/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: This is just changing the function signatures and callers, not how Variables is used. |
| Comment by Githook User [ 14/Nov/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: Now we are assigning Ids but still using names to get/set variables at run time. The main |
| Comment by Githook User [ 14/Nov/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: VariablesParseState isn't yet used, this just pushes it through the parsing so that it can be used |