[SERVER-11834] listCommands show write commands not taking locks Created: 22/Nov/13  Updated: 13/Sep/16  Resolved: 14/Jan/14

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 2.5.4
Fix Version/s: 2.5.5

Type: Bug Priority: Minor - P4
Reporter: Randolph Tan Assignee: Spencer Brody (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-12019 Remove "lockType" from commands "help... Closed
Related
is related to SERVER-12019 Remove "lockType" from commands "help... Closed
Operating System: ALL
Participants:

 Description   

listCommands output show the commands as no-lock and can be confusing to users since write commands actually take write locks.

...

delete: no-lock
delete documents

...

insert: no-lock
insert documents

...

update: no-lock
update documents



 Comments   
Comment by Githook User [ 14/Jan/14 ]

Author:

{u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@10gen.com'}

Message: SERVER-11834 Remove lockType field from listCommands output
Branch: master
https://github.com/mongodb/mongo/commit/76fc4baa3004af615066ba82ef458908ff2eb041

Comment by Eliot Horowitz (Inactive) [ 22/Nov/13 ]

Yes, please just delete the locks field from that output.

Comment by Spencer Brody (Inactive) [ 22/Nov/13 ]

I actually think we should just remove that field from the listCommands output. It's wrong for a bunch of other commands also, for example all the commands for manipulating users/roles can also take write locks, but report no lock. That output is coming from the lockType() function on Command objects, which no longer controls how most commands do their locking.

Generated at Thu Feb 08 03:26:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.