[SERVER-11978] Remove #defines from platform/basic.h for __builtin_str* functions. Created: 05/Dec/13 Updated: 11/Jul/16 Resolved: 11/Dec/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.5 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | Mathias Stearn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Participants: |
| Description |
|
These #defines cause our code to violate the one-definition rule, especially in the driver, but probably even in the server itself. Mathias confirms that with current compilers, our existing benchmarks no longer indicate a performance advantage. |
| Comments |
| Comment by Githook User [ 11/Dec/13 ] |
|
Author: {u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}Message: It no longer shows performance benefit on current compiler. |