[SERVER-12170] Do not call relinquish() when not vetoing an election Created: 19/Dec/13 Updated: 11/Jul/16 Resolved: 20/Dec/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | 2.5.4 |
| Fix Version/s: | 2.4.10, 2.5.5 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Matt Dannenberg | Assignee: | Matt Dannenberg |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
| Comments |
| Comment by Githook User [ 09/Mar/14 ] |
|
Author: {u'username': u'dannenberg', u'name': u'Matt Dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by Githook User [ 20/Dec/13 ] |
|
Author: {u'username': u'dannenberg', u'name': u'Matt Dannenberg', u'email': u'matt.dannenberg@10gen.com'}Message: |
| Comment by Eric Milkie [ 19/Dec/13 ] |
|
This is no point to calling relinquish() there. I looked up when it was added and I believe it was simply a mistake. Let's remove it from the elect response command handling. |
| Comment by Matt Dannenberg [ 19/Dec/13 ] |
|
In Consensus::electCmdReceived() |
| Comment by Eric Milkie [ 19/Dec/13 ] |
|
How are we hitting relinquish() if we're not in state PRIMARY? |