[SERVER-12422] cleanupOrphaned should not need remote metadata refresh if metadata exists Created: 21/Jan/14  Updated: 22/Feb/14  Resolved: 04/Feb/14

Status: Closed
Project: Core Server
Component/s: Logging, Sharding
Affects Version/s: 2.5.4
Fix Version/s: 2.6.0-rc0

Type: Bug Priority: Minor - P4
Reporter: Matt Dannenberg Assignee: Randolph Tan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to DOCS-2674 changes to cleanuporphaned command Closed
Operating System: ALL
Participants:

 Description   

By design, we should be able to safely clean up orphaned data using only local information (unless we are not sure if we're a shard or not). Keep thing simple by only refreshing if our local information is unset (i.e. needMetadataFor() is false).

Previously was a ticket tracking error messages:

"failed to refresh shard metadata: cannot refresh metadata for foo.bar before shard name has been set"



 Comments   
Comment by Randolph Tan [ 04/Feb/14 ]

This removes the behavior introduced in SERVER-12178. So, the command no longer returns the same stoppedAt as the one passed to startingFromKey. With this change, the cleanup command just continues to perform the deletion since it is safe to do so.

Comment by Githook User [ 04/Feb/14 ]

Author:

{u'username': u'renctan', u'name': u'Randolph Tan', u'email': u'randolph@10gen.com'}

Message: SERVER-12422 cleanupOrphaned should not need remote metadata refresh if metadata exists

Fix empty errmsg
Branch: master
https://github.com/mongodb/mongo/commit/2c0785d40795e4e0f06e325e42dd47c9dbb8a97b

Comment by Githook User [ 04/Feb/14 ]

Author:

{u'username': u'renctan', u'name': u'Randolph Tan', u'email': u'randolph@10gen.com'}

Message: SERVER-12422 cleanupOrphaned should not need remote metadata refresh if metadata exists
Branch: master
https://github.com/mongodb/mongo/commit/5fbccda28cf10f074e5ae079541a393476bc5565

Comment by A. Jesse Jiryu Davis [ 22/Jan/14 ]

IMO the cleanupOrphaned response should include a descriptive error message and 'ok' should be 0.

Generated at Thu Feb 08 03:28:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.