[SERVER-12520] Typo in jstests/misc/biginsert.js Created: 29/Jan/14 Updated: 14/Mar/17 Resolved: 11/Jun/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | 2.5.4 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Guy Hoozdis | Assignee: | Matt Kangas |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | pull-request, tests | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
All supported build environments |
||
| Issue Links: |
|
||||||||
| Participants: | |||||||||
| Description |
|
Variable assignment is unintentionally skipped. https://github.com/mongodb/mongo/blob/master/jstests/misc/biginsert.js#3 I believe that this (which is what is in the master branch now) o = o + o; was intended to be this o = o + o; Unless there is some subtlety about this test or JS that would make that line significant, but I think it was just a simple mistake. I know you guys have more important things to be chasing down. This is just a chance for me to follow the instructions for contributors. I submitted this other ticket on this same issue before I created this one. Since I want to submit a pull request don't think that ticket was filled under the correct project. https://jira.mongodb.org/browse/DOCS-2617 Documentation: There wasn't much in the way of documentation or even code comments in this test. That might indicate that nobody is taking this test seriously (it gets no love). There are some quirky attempt to use the test data (as both a field name and the associated value), but it is unclear to me at this point if that is even a reasonable attempt at stressing the server or at breaking it's data structures. I can look into that some more, but I seem to remember load testing being addressed in a more rigorous manner somewhere else. Even some comments / documentation referencing that work would be helpful. |
| Comments |
| Comment by Matt Kangas [ 11/Jun/14 ] |
|
Pull request closed March 10. Test removed in 0dabee8 May 14. |