[SERVER-12720] Needless inclusion of file_allocator in util/util.cpp creates C++ client driver dependency on posix_fadvise Created: 13/Feb/14 Updated: 11/Jul/16 Resolved: 14/Feb/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Client |
| Affects Version/s: | None |
| Fix Version/s: | 2.6.0-rc0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Participants: |
| Description |
|
util/util.cpp, which implements some of goodies.h, includes file_allocator.h, but only acquires the StaticObserver from it. However, by pulling in file_allocator, it creates a dependency on posix_fadvise.cpp, which is then also required in the driver. Changing util.cpp to only require mutex.h to get the static observer removes both file_allocator.h and posix_fadvise.h from the files required to build the client driver. |
| Comments |
| Comment by Githook User [ 14/Feb/14 ] |
|
Author: {u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@10gen.com'}Message: |
| Comment by Andrew Morrow (Inactive) [ 14/Feb/14 ] |
|
And paths.cpp |
| Comment by Andrew Morrow (Inactive) [ 13/Feb/14 ] |
|
Also obviated is util/file.cpp |
| Comment by Andrew Morrow (Inactive) [ 13/Feb/14 ] |
|
This also obviates the need for all of the processinfo files in the driver |