[SERVER-13051] Change smoke.py to default to commands shell write mode Created: 05/Mar/14 Updated: 19/Oct/15 Resolved: 19/Oct/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Critical - P2 |
| Reporter: | Scott Hernandez (Inactive) | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participants: |
| Description |
|
Currently, during the transition of jstests to the jsCore* suites we have more than one shell write mode being used:
The change would be to run with shell-write-mode of commands unless overridden by the suite explicitly, like for the gle suite. In addition we need to change the "default" when no explicit shell-write-mode is specified as an argument to align to what is required for each suite/test. |
| Comments |
| Comment by Kamran K. [ 19/Oct/15 ] |
|
Thanks for taking a look, Dave. I'm resolving this ticket as Gone Away because I agree that it doesn't seem like further work is strictly required here. |
| Comment by David Storch [ 19/Oct/15 ] |
|
kamran.khan, I believe the current state of things is that the shell's default writeMode is "commands" and resmoke.py does not specify a writeMode by default. Therefore, I believe the work described here was already done as part of the resmoke project and we can close as "Gone Away". We could consider changing all the resmoke config files to explicitly specify the writeMode (overriding in Evergreen config as appropriate), since we explicitly specify a readMode in each suite. However, this does not seem like required work. |
| Comment by Kamran K. [ 16/Oct/15 ] |
|
david.storch, can you weigh in on whether we still want to do this for Evergreen/resmoke.py? |