[SERVER-13123] All callers of PlanExecutor::getNext need to deal with error returns Created: 10/Mar/14  Updated: 18/Mar/16  Resolved: 18/Feb/16

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: 2.6.0-rc1
Fix Version/s: 3.3.2

Type: Bug Priority: Major - P3
Reporter: Mathias Stearn Assignee: Tess Avitabile (Inactive)
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-16141 some commands abort silently when ind... Closed
is duplicated by SERVER-16877 dataSize command doesn't report some ... Closed
is duplicated by SERVER-20278 filemd5 command hides execution error... Closed
is duplicated by SERVER-13160 dbcommands.cpp::CmdDatasize misleadin... Closed
Related
related to SERVER-22871 splitChunk needs to check for a faile... Closed
is related to SERVER-2454 Queries that are killed during a yiel... Closed
is related to SERVER-22535 Some index operations (drop index, ab... Closed
is related to SERVER-20278 filemd5 command hides execution error... Closed
is related to SERVER-22844 Aggregate command should return error... Closed
is related to SERVER-16920 Better error messages for operations ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Query F (02/01/16), Query 10 (02/22/16)
Participants:

 Description   

Some callers merely warn to the log if the Runner reports errors while others don't even check for errors. Both of these will lead to incorrect results being returned to the user rather than reporting an error. Searching the code for PlanExecutor::ADVANCED should show all loops that iterate a runner.

Incomplete list of things that ignore errors:

  • delete (will report success even though some matching docs won't be deleted)
  • dbhash (will return the incorrect hash)
  • count
  • distinct (will return an incomplete list of distinct values, with no indication of incompleteness)
  • findAndModify (can upsert even if something already matches)
  • geoNear
  • mr
  • validate


 Comments   
Comment by Githook User [ 18/Feb/16 ]

Author:

{u'username': u'tessavitabile', u'name': u'Tess Avitabile', u'email': u'tess.avitabile@mongodb.com'}

Message: SERVER-13123 All callers of PlanExecutor::getNext need to deal with error returns
Branch: master
https://github.com/mongodb/mongo/commit/a12f3f807900829a36f97dc777f98bebe74ad591

Comment by J Rassi [ 09/Dec/14 ]

Errors are now handled correctly in findAndModify, as part of SERVER-16469 (2.8.0-rc3).

Generated at Thu Feb 08 03:30:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.