[SERVER-13256] Remove pch.h Created: 18/Mar/14  Updated: 18/Sep/15  Resolved: 15/Jan/15

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.0.0-rc6

Type: Improvement Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 2
Labels: community-team
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-17068 3.0.0-rc6 cannot build with the 3.25 ... Closed
related to SERVER-16604 Improve integration with rocks Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

pch.h needs to removed

Steps

  • Add required headers to each .h and .cpp
  • Qualify shared_ptr, and other boost framework classes
  • Add using declarations for std:: members in Cpp files, and qualify in .h files
  • Remove exit functions from pch.h


 Comments   
Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component

(cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d)
Branch: v3.0
https://github.com/mongodb/mongo/commit/a0986ff9cd64e935a37f4d0b254728712866c579

Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component

(cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d)
Branch: v3.0
https://github.com/mongodb/mongo/commit/a0986ff9cd64e935a37f4d0b254728712866c579

Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component

(cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d)
Branch: v3.0
https://github.com/mongodb/mongo/commit/a0986ff9cd64e935a37f4d0b254728712866c579

Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component
Branch: master
https://github.com/mongodb/mongo/commit/107e3bfcd71936a876231517ee52aa6ca80b7e1d

Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component
Branch: master
https://github.com/mongodb/mongo/commit/107e3bfcd71936a876231517ee52aa6ca80b7e1d

Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component
Branch: master
https://github.com/mongodb/mongo/commit/107e3bfcd71936a876231517ee52aa6ca80b7e1d

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-13256 fixed rocksdb compilation
Branch: master
https://github.com/mongodb/mongo/commit/34cc34baff2345d6356b152e6aac4a8eed5b1d41

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Rename chunk_diff-inl.cpp to a header to reflect its usage
Branch: master
https://github.com/mongodb/mongo/commit/653169a891f612afef80ec149194f11197fbaa3b

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove pch.h
Branch: master
https://github.com/mongodb/mongo/commit/849e93f22089d2a2e0cdc5891037b116602cdd72

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove debug_util.h from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/d03f92f7822e46bec820c3e0d3cd39f81fc6bf80

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove std library includes and using namespace std from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/ca51fdc7bcf08b59bd61cde173fae42d6db81b1d

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Add usings and qualifications for names from namespace std
Branch: master
https://github.com/mongodb/mongo/commit/9f30e21c627e4c73ab0b44e45b7ce657b3e2619f

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Add std namespace qualifications in headers
Branch: master
https://github.com/mongodb/mongo/commit/44cafa7dddde7510aa0a05efce807a2e294fdc6d

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Add usings/quals to not depend on pch.h
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/b7790be6f1d54f2864ec1f19ba043f353efcbfdb

Comment by Githook User [ 06/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove shared_ptr from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/3ec53687da4702d348f1b55eda5e01bd26f36c4b

Comment by Githook User [ 06/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove boost/utility from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/738e17c6366b416b60dfcebaff99ee2a357c7fcf

Comment by Githook User [ 06/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove scoped_ptr from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/e782819da4ce547272c653ec85984cacf5e60ff2

Comment by Githook User [ 06/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove scoped_array from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/0c4d932be42022627cd1e8a826fc69cd3edac23f

Comment by Githook User [ 06/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove intrusive_ptr from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/0292094b0673177a24bcfe265b82a36dfb4da362

Comment by Githook User [ 06/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove smart_ptr.hpp from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/e6216fcecb292789846125db28165029727555b9

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Scope iostream more narrowly
Branch: master
https://github.com/mongodb/mongo/commit/99ce8f87a164d48fd899699bb678d456eaa1323a

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove using of dynamic_ptr_cast from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/b118aa80968dd9e585f8f34b4599bbabefdf6a99

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Sort system and boost headers in pch and remove dups
Branch: master
https://github.com/mongodb/mongo/commit/22fab7c71ff006587b2561eae693c10424e27837

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove useless pch.cpp
Branch: master
https://github.com/mongodb/mongo/commit/8ef3942451da35353b7f164d190d7185799fa381

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Prohibit new uses of pch.h
Branch: master
https://github.com/mongodb/mongo/commit/c43d8e0aa47f868a8b3cd7367d2f21c717e2ca3c

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove inclusion of export_macros from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/fe1a1055a60eef0b37ca389a4c516f27a17d04d1

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Make debug_util macros only
Branch: master
https://github.com/mongodb/mongo/commit/997256fc799e815fbdb4c1b163afcb2aca6dc249

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move win32 strcasecmp to somewhere saner
Branch: master
https://github.com/mongodb/mongo/commit/a341230b5ebbff4d6c097d5f2bab91545ed97f93

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove assert_util from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/3912341a289978c4b56d242b81aa9302d0f992f6

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove goodies.h
Branch: master
https://github.com/mongodb/mongo/commit/89a50e9e2934b9b44462a3a81ac429596cb07fd8

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Scope handle typedef to mmap subsystem and only define on non-windows
Branch: master
https://github.com/mongodb/mongo/commit/32b4f794aafd9bd3fb8e5a8bdb858c3066d058ec

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move string utils from goodies.h to str.h
Branch: master
https://github.com/mongodb/mongo/commit/8bff2b205a54d0616e4b3ec04e3c1c3435ff9d11

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move PRINT macro to own header and incldue where needed
Branch: master
https://github.com/mongodb/mongo/commit/7c134b66ea15ad39985800a43874413423653809

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove strcpy_s, used only in windows only code, from goodies.h
Branch: master
https://github.com/mongodb/mongo/commit/d01e0bfbfb809ff4a7ad7d410840abeb5a392b77

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove unused functions from goodies.h
Branch: master
https://github.com/mongodb/mongo/commit/7d0330733bf33779869dab27762dff30b0f7ad59

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move observer to mutex.cpp and remove util.cpp
Branch: master
https://github.com/mongodb/mongo/commit/21e1811a4e92c72b095d93e5cadb1d3428605d42

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move hexdump out of goodies.h and into hex.h
Branch: master
https://github.com/mongodb/mongo/commit/d61eb5e43f1efe634be1a383ea451f8579dfb9fa

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove unused isPrime and nextPrime functions
Branch: master
https://github.com/mongodb/mongo/commit/ce14697bff987f49262f5da9f14e33f913ae9339

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move ThreadSafeString to own file
Branch: master
https://github.com/mongodb/mongo/commit/e46896c23c4b411f4936fd41068d61a7922418a7

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Move ptr<T> out of goodies to own header
Branch: master
https://github.com/mongodb/mongo/commit/939db8fd31790eff642abd446552294c66c5ff8a

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Migrate goodies boost headers/usings to pch.h
Branch: master
https://github.com/mongodb/mongo/commit/60e074c4c123f559c126ea01877e7bdc33f1bbbd

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove C headers from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/eb8e7844901e3fe692c2879a6a3af1433eb87050

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove boost/version.hpp from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/e3d08996498463ba7827cff79783bc49f38f3469

Comment by Githook User [ 05/Jan/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-13256 Remove allocator.h from pch.h
Branch: master
https://github.com/mongodb/mongo/commit/01ebe59274ecc2f84f53a662663d043b15acc2e6

Comment by Ramon Fernandez Marina [ 20/May/14 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-13256: Remove pch - qualify std in headers

Branch: master
https://github.com/mongodb/mongo/commit/f2bfd36a6f3eb7e7e2587268be3cc12636703d42

Comment by Githook User [ 07/May/14 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: SERVER-13256: Remove exit functions from pch
Branch: master
https://github.com/mongodb/mongo/commit/b85d1a63d3d19e0fc07b8ec159214ee92ae3d097

Generated at Thu Feb 08 03:31:08 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.