[SERVER-13284] Tools should use appropriate singular/plural forms of "document" and "object" Created: 19/Mar/14 Updated: 04/Sep/14 Resolved: 19/May/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Tools |
| Affects Version/s: | 2.4.9, 2.7.0 |
| Fix Version/s: | 2.7.1 |
| Type: | Bug | Priority: | Trivial - P5 |
| Reporter: | Sean Wilkinson | Assignee: | Benety Goh |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Steps To Reproduce: | 1. Create a collection with only one document in it: )' 2. Dump the collection to see incorrect English: 3. Restore it again to see more incorrect English: I have included three pictures of the results of these steps: one for 2.4.9 release, one for latest "origin/master" (2.7.0-pre) without my changes, and one for latest "origin/master" with my changes. It probably applies to all versions in between. |
||||||||
| Sprint: | Server 2.7.1 | ||||||||
| Participants: | |||||||||
| Description |
|
This issue is trivial, but addressing it does add a little polish to MongoDB. Tools I use every day like `mongodump` and `mongorestore` for retrieving and archiving new data sometimes produce output like "imported 1 documents", "processed 1 documents", and "wrote 1 documents". I have opened this issue to accompany a pull request from GitHub in which I have corrected a few of these grammar mistakes by adding conditionals that choose the appropriate noun form. All tests still pass on my personal machine, a MacBook Air running Mavericks (OS X 10.9.2), but I have only tested with the "origin/master" branch from GitHub. I'm not sure whether new tests are really necessary for this sort of thing, so I haven't written any yet. |
| Comments |
| Comment by Githook User [ 19/May/14 ] |
|
Author: {u'username': u'wilkinson', u'name': u'Sean Wilkinson', u'email': u'sean@mathbiol.org'}Message: Signed-off-by: Benety Goh <benety@mongodb.com> |
| Comment by Sean Wilkinson [ 27/Mar/14 ] |
|
Here is the output after I changed occurrences of the word "object" to "document", per communications on GitHub. |