[SERVER-13287] Addition of debug symbols has doubled compile time Created: 20/Feb/14 Updated: 11/Jul/16 Resolved: 17/Apr/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build, Packaging |
| Affects Version/s: | None |
| Fix Version/s: | 2.6.1, 2.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Ian Whalen (Inactive) | Assignee: | Matt Kangas |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backport Completed: | |
| Participants: |
| Description |
| Comments |
| Comment by Githook User [ 17/Apr/14 ] | |||||||||
|
Author: {u'username': u'deafgoat', u'name': u'Wisdom Omuya', u'email': u'deafgoat@gmail.com'}Message: Signed-off-by: Matt Kangas <matt.kangas@mongodb.com> | |||||||||
| Comment by Adinoyi Omuya [ 17/Apr/14 ] | |||||||||
|
You're right! I completely missed it as well, sorry about the mistake. Looks like compile times are significantly lower across all linux/unix flavor buildvariants. | |||||||||
| Comment by Matt Kangas [ 17/Apr/14 ] | |||||||||
|
adinoyi.omuya@10gen.com - your commits in pull/658 said "MCI-13287". Should have read " I squashed them and tested locally, but I failed to notice this before pushing to master.
| |||||||||
| Comment by Githook User [ 26/Mar/14 ] | |||||||||
|
Author: {u'username': u'monkey101', u'name': u'Dan Pasette', u'email': u'dan@10gen.com'}Message: Revert " This reverts commit e73399e0e696aaaf1e859533e10cc2b74d46994f. | |||||||||
| Comment by Githook User [ 25/Mar/14 ] | |||||||||
|
Author: {u'username': u'deafgoat', u'name': u'Wisdom Omuya', u'email': u'deafgoat@gmail.com'}Message: Signed-off-by: Matt Kangas <matt.kangas@mongodb.com> | |||||||||
| Comment by Andrew Morrow (Inactive) [ 20/Feb/14 ] | |||||||||
|
Yeah make_archive is a bit of a travesty. SCons knows how to make archives by way of its Package rule, but we don't use that. I see no reason that making make_archive slightly worse (one more level of shelling) to make build times better (we all rejoice), would be a bad tradeoff. | |||||||||
| Comment by Michael O'Brien [ 20/Feb/14 ] | |||||||||
|
For example, see the log timing here: Suspicious code in make_archive.py: | |||||||||
| Comment by Michael O'Brien [ 20/Feb/14 ] | |||||||||
|
The issue is in mongo/buildscripts/make_archive.py which is called by scons to generate the archive with nonstripped binaries. | |||||||||
| Comment by Andrew Morrow (Inactive) [ 20/Feb/14 ] | |||||||||
|
ian@10gen.com Is there a link to the MCI config change? The listed git hashes for the mongodb repo don't have anything to do with debug symbols. |