[SERVER-13617] Clean up some -Wextra warnings Created: 16/Apr/14  Updated: 11/Jul/16  Resolved: 01/May/14

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 2.7.0

Type: Task Priority: Major - P3
Reporter: Mathias Stearn Assignee: Mathias Stearn
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

For this pass will ignore -Wunused-parameter and -Wmissing-field-initializers since I don't think we want to fix them.



 Comments   
Comment by Githook User [ 01/May/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13617 don't compare pointers to 0 using >

GCC with -Wextra gives the following message in these cases:

ordered comparison of pointer with integer zero
Branch: master
https://github.com/mongodb/mongo/commit/0ee4735ab8fb718b40e2049d014e17736035ba46

Comment by Githook User [ 01/May/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13617 remove const qualifiers on primitive return types

These tripped -Wignored-qualifiers on clang. With this change we now compile
cleanly on clang with -Wextra with only the following warnings disabled.
Neither seems worth fixing.

-Wno-unused-parameter
-Wno-missing-field-initializers
Branch: master
https://github.com/mongodb/mongo/commit/35562387e6d3e23245529589e264be3551f2dd0b

Generated at Thu Feb 08 03:32:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.