[SERVER-13738] Get rid of StackChecker Created: 25/Apr/14  Updated: 11/Jul/16  Resolved: 25/Apr/14

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 2.7.0

Type: Task Priority: Major - P3
Reporter: Mathias Stearn Assignee: Mathias Stearn
Resolution: Done Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

After discussion, we decided that it does more harm than good.

Issues with the StackChecker:

1) Debug builds on linux already use a 50% smaller stack so we would catch getting anywhere near a stack overflow.
2) It broke in the presence of compiler optimizations and sanitizers (which correctly diagnosed it as a buffer overrun).
3) Due to 2, it was disabled on all of our builders.
4) Due to 2, it could never tell us how much stack we actually used in release builds, since optimizations effect stack usage.
5) It would fail or pass based on your choice of compiler.
6) Our response to it failing was always just to raise the limit.



 Comments   
Comment by Githook User [ 25/Apr/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13738 RIP StackChecker
Branch: master
https://github.com/mongodb/mongo/commit/84ea70be95e75eacddb05a8b85167741ec699556

Generated at Thu Feb 08 03:32:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.