[SERVER-13916] building with --js-engine=none still tries to build the shell Created: 13/May/14  Updated: 25/Jan/17  Resolved: 13/Feb/15

Status: Closed
Project: Core Server
Component/s: Build, JavaScript
Affects Version/s: None
Fix Version/s: 3.1.0

Type: Bug Priority: Minor - P4
Reporter: Michael Hudson-Doyle Assignee: Benety Goh
Resolution: Done Votes: 0
Labels: arm64
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

Hi,

If you run scons --js-engine=none all it still tries to build the shell. It fails to link, but even if it linked it's not like there's anything useful it can do, I think it should just not try to build it in this case.

Cheers,
mwh



 Comments   
Comment by Githook User [ 13/Feb/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-13916 added scons flag --server-js to build mongod without JavaScript support while still building shell

Additional changes:
fixed scons --noshell flag
fixed scons flag --js-engine=none to imply --noshell
Branch: master
https://github.com/mongodb/mongo/commit/00fe4ffaf00a68a91e8dd6232984d5b80a1ddacb

Comment by Michael Hudson-Doyle [ 21/May/14 ]

No, not yet (it's not really arm64 specific...). I haven't submitted a PR yet.

Comment by Benety Goh [ 20/May/14 ]

Can we close this ticket now that the other arm64 PR's have been merged?

Comment by Michael Hudson-Doyle [ 18/May/14 ]

Yeah, I'm planning to submit a PR to do something like that when I find a spare tuit.

Comment by Matt Kangas [ 13/May/14 ]

IMO, the simplest and most correct fix is to make "all" and "mongo" invalid targets when "--js-engine=none" is specified.

Generated at Thu Feb 08 03:33:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.