[SERVER-13951] uncommited UnitOfWork needs to rollback Created: 15/May/14  Updated: 15/May/20  Resolved: 21/Oct/14

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 2.7.8

Type: Task Priority: Major - P3
Reporter: Eliot Horowitz (Inactive) Assignee: Geert Bosch
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-14933 Failed to insert into capped collecti... Closed
Related
related to SERVER-26335 Initial sync with buildIndexes=false ... Closed
related to SERVER-11716 renameCollection allows background in... Closed
Tested
Participants:
Linked BF Score: 15

 Comments   
Comment by Githook User [ 13/Jan/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-13951: Remove now obsolete comment
Branch: master
https://github.com/mongodb/mongo/commit/69635e9248611036d5eeb415ec72314a69438604

Comment by Githook User [ 04/Nov/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Remove ROLLBACK_ENABLED flag

Rollback is now required so we don't need a way to turn it off.
Branch: master
https://github.com/mongodb/mongo/commit/cc00f648f2cc51994d91dc6c24df9d93a7c3c4ba

Comment by Githook User [ 31/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 pass false to invalidateAll() when dropping collection

true should only be passed from the CollectionCursorCache destructor.
Branch: master
https://github.com/mongodb/mongo/commit/0f2eefec0bffac9682be5628449c676d22a08462

Comment by Githook User [ 30/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 KVEngines shouldn't drop anything when renaming.
Branch: master
https://github.com/mongodb/mongo/commit/a28c5fad93a81c3475f884c690aa9f83a873dac0

Comment by Githook User [ 30/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Allow rollback of dropping an index
Branch: master
https://github.com/mongodb/mongo/commit/b7f7ad839bf7a08ff2f73fcba367632c5192c84d

Comment by Githook User [ 30/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Fix rollback of CollectionMap
Branch: master
https://github.com/mongodb/mongo/commit/f30ddd8d162ead9c696195d7bc6aef02d3acecc7

Comment by Githook User [ 27/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Changes that depend on rollback
Branch: master
https://github.com/mongodb/mongo/commit/9c6ec970c5e7c7c8058008d30951430d149b3968

Comment by Githook User [ 03/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 ROLLBACK_ENABLED=1
Branch: master
https://github.com/mongodb/mongo/commit/f24551951e5513274a7875ebc799d41de838f6ac

Comment by Githook User [ 01/Oct/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Clean up WUOWs in a few dbtests
Branch: master
https://github.com/mongodb/mongo/commit/d4d32caffb9135545811769a38c246dab67df917

Comment by Githook User [ 12/Sep/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Add a WUOW around logOp in applyOps
Branch: master
https://github.com/mongodb/mongo/commit/89ddd9477913e437a563faec872a397af801575d

Comment by Githook User [ 28/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 extra logging for rollback to help with debugging

Will be removed from default log level with SERVER-15043
Branch: master
https://github.com/mongodb/mongo/commit/5486963a3549b69190a2e3adc584db312111abaf

Comment by Githook User [ 28/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Give DurRecoveryUnit the semantics we want
Branch: master
https://github.com/mongodb/mongo/commit/87702f82174828817ce7128abd0a5df65ec6abd5

Comment by Githook User [ 28/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Don't register changes when loading existing collections in MMAPv1
Branch: master
https://github.com/mongodb/mongo/commit/a4bb7f82119a113eba450d82be7b7aad89886562

Comment by Githook User [ 28/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Clean up creation of index namespaces for MMAPv1
Branch: master
https://github.com/mongodb/mongo/commit/b6a90b9ac8045665e5ba9024842493b1dce10fc7

Comment by Githook User [ 26/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Clean up OperationContext usage in dbtests
Branch: master
https://github.com/mongodb/mongo/commit/f055e0f661c44b4f73d0b901cbf1dc0de0d303db

Comment by Githook User [ 26/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Split compact up into WriteUnitOfWorks

Each document is its own WUOW and we maintain consistency with every document.
This was the last caller of isCommitNeeded() so that method has been removed.
Branch: master
https://github.com/mongodb/mongo/commit/3a0cd3faae366127d1a8f2099bdcd902bc18d0a1

Comment by Githook User [ 20/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Better scoping for many WUOWs
Branch: master
https://github.com/mongodb/mongo/commit/562c8cb3faff5e9fc0acdc45db8dc2d498eb2000

Comment by Githook User [ 13/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 WUOW now takes whole OperationContext, not just RecoveryUnit

This will make it possible to implement two-phase locking.
Branch: master
https://github.com/mongodb/mongo/commit/e33a6c57607871f1b204bd5e1d8ea4a14ad06452

Comment by Githook User [ 13/Aug/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Split index building in to UnitOfWork-sized stages

All index builds now go through the MultiIndexBuilder as its API was already
close to ideal. The following tickets have also been addressed by this commit:

SERVER-14710 Remove dropDups
SERVER-12309 Cloner build indexes in parallel
SERVER-14737 Initial sync uses bg index building
SERVER-9135 fast index build for initial sync
SERVER-2747 can't kill index in phase 2
SERVER-8917 check error code rather than assuming all errors are dups
SERVER-14820 compact enforces unique while claiming not to
SERVER-14746 IndexRebuilder should be foreground and fail fatally
Branch: master
https://github.com/mongodb/mongo/commit/00913e47de5aced5267e44e82ac9e976bbaac089

Comment by Githook User [ 28/Jul/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Use a WriteUnitOfWork for each document in update and delete
Branch: master
https://github.com/mongodb/mongo/commit/c75a777a2c438139b88e7d92eacd29e48735e7c2

Comment by Githook User [ 28/Jul/14 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert.bosch@mongodb.com'}

Message: SERVER-13951: Add rollback of collection metadata

This implements rollback of collection creation or dropping, including
associated indexes.
Branch: master
https://github.com/mongodb/mongo/commit/553266111d7295aff03868cdfbf22e08985764db

Comment by Githook User [ 09/Jul/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Plumb OperationContext into DBDirectClients used for writing
Branch: master
https://github.com/mongodb/mongo/commit/4939ccc6ebb0f7a61121e77ceeebd75d8841606a

Comment by Githook User [ 01/Jul/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 Improve Rollback code for DurRecoveryUnit
Branch: master
https://github.com/mongodb/mongo/commit/676af72da3eb3dc0b5b9581e3254a0ed385e1dbb

Comment by Githook User [ 05/Jun/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-13951 First phase of rollback implementation

This reverts commit 64e3b85a7c8a4a6ea7c68f25ae27780c702cdfb5.
Branch: master
https://github.com/mongodb/mongo/commit/96a6b2e79f091bc20a54534c5ae9e3240d2aa3b9

Comment by Githook User [ 04/Jun/14 ]

Author:

{u'username': u'markbenvenuto', u'name': u'Mark Benvenuto', u'email': u'mark.benvenuto@mongodb.com'}

Message: Revert "SERVER-13951 First phase of rollback implementation"

Broke Windows Compile

This reverts commit 8b0d5c879339e16f06829ebb4265e54b1a356b2a.
Branch: master
https://github.com/mongodb/mongo/commit/64e3b85a7c8a4a6ea7c68f25ae27780c702cdfb5

Comment by Githook User [ 04/Jun/14 ]

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13951 First phase of rollback implementation

Currently disabled until it is ready.
Branch: master
https://github.com/mongodb/mongo/commit/8b0d5c879339e16f06829ebb4265e54b1a356b2a

Comment by Mathias Stearn [ 16/May/14 ]

This commit was meant for this ticket:

Author:

{u'username': u'RedBeard0531', u'name': u'Mathias Stearn', u'email': u'mathias@10gen.com'}

Message: SERVER-13912 Better write intents for RSV1Base::deleteRecord

Only declare intent to write to areas we actually write to, rather than the
entire Extent header. Most of the time (ie unless deleting the first or last
record) no write intents should be declared.
Branch: master
https://github.com/mongodb/mongo/commit/7b1fc98747bd70134da28c8991ddf6dd90d90c87

Comment by Eliot Horowitz (Inactive) [ 15/May/14 ]

One (maybe more) test disabled until this is done, grep for SERVER-13951

Generated at Thu Feb 08 03:33:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.