[SERVER-13961] Move LockState under OperationContext Created: 15/May/14 Updated: 02/Aug/18 Resolved: 29/Jul/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Concurrency |
| Affects Version/s: | None |
| Fix Version/s: | 2.7.5 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Kaloian Manassiev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||
| Description |
|
This change will move LockState under OperationContext, so that it is no longer retrieved from the tread-local state. |
| Comments |
| Comment by Githook User [ 29/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 28/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: The JS framework uses DBDirectClient, which requires OperationContext in This change also makes dbEval not use pooled scopes and create a new scope |
| Comment by Githook User [ 24/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 23/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 18/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: There are no functional changes in this commit, just preparation for the |
| Comment by Githook User [ 18/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: These are causing deadlocks if LockState is removed from TLS because of |
| Comment by Githook User [ 10/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 01/Jul/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Time tracking and database access in Client::Context require access to the This is in preparation for removing LockState from Client. |
| Comment by Githook User [ 30/Jun/14 ] |
|
Author: {u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}Message: Revert " This reverts commit e1f5a39b1b625d04752be13f39c774e579b64cd8. |
| Comment by Githook User [ 30/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Time tracking and database access in Client::Context require access to the This is in preparation for removing LockState from Client. |
| Comment by Githook User [ 28/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Revert " This reverts commit 52edab726185cbba1401cb46de221fb3d1cb0408. |
| Comment by Githook User [ 28/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Time tracking and database access in Client::Context require access to the This is in preparation for removing LockState from Client. |
| Comment by Githook User [ 27/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 27/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: All remaining places, which call dbexit, outside of repl are in response The repl calls happen at secondary replica startup time, so no writes |
| Comment by Githook User [ 27/Jun/14 ] |
|
Author: {u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}Message: Revert " This reverts commit e1dca2cdeed7cf5549a85d487def752d600af244. |
| Comment by Githook User [ 26/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 26/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This replaces the need to iterate through the list of registered Clients This is in preparation for removing LockState from TLS. |
| Comment by Githook User [ 17/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This change prepares for removing dbexit altogether. |
| Comment by Githook User [ 17/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This change prepares for removing dbexit altogether. |
| Comment by Githook User [ 13/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 13/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: So we stop using LockState from OperationContext for all durability |
| Comment by Githook User [ 05/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: These are the most obvious usages, which do not require any refactoring. |
| Comment by Githook User [ 05/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: When called from DBDirectClient, it already skips the check if running |
| Comment by Githook User [ 03/Jun/14 ] |
|
Author: {u'username': u'hkhalsa', u'name': u'Hari Khalsa', u'email': u'hkhalsa@10gen.com'}Message: |
| Comment by Githook User [ 03/Jun/14 ] |
|
Author: {u'username': u'hkhalsa', u'name': u'Hari Khalsa', u'email': u'hkhalsa@10gen.com'}Message: |
| Comment by Githook User [ 03/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: All places which call dbHolder are verifiably under the appropriate lock, |
| Comment by Githook User [ 03/Jun/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 30/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This is part of the changes to move LockState be part of OperationContext |
| Comment by Githook User [ 30/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This is part of the changes to move LockState be part of OperationContext |
| Comment by Githook User [ 28/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Revert " This reverts commit 4625ce3430892eac2f53b870ca0a24501f3c15f0. |
| Comment by Githook User [ 28/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Revert " This reverts commit 0672061deb58aac931912bed68d014247c581968. |
| Comment by Githook User [ 28/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This is part of the changes to move LockState be part of OperationContext |
| Comment by Githook User [ 28/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This is part of the changes to move LockState be part of OperationContext |
| Comment by Githook User [ 28/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: This change makes all write intents go straight to the global write |
| Comment by Ramon Fernandez Marina [ 20/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Also clean-up some of the code under LockState, in preparation from moving |
| Comment by Githook User [ 16/May/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: We will no loger build with global locking on. |