[SERVER-14049] build fail if python jsmin library is installed on system Created: 26/May/14 Updated: 04/Sep/14 Resolved: 27/May/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 2.4.10, 2.6.1 |
| Fix Version/s: | 2.7.2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Ultrabug | Assignee: | Benety Goh |
| Resolution: | Done | Votes: | 0 |
| Labels: | community-team | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Server 2.7.2 |
| Participants: |
| Description |
|
Gentoo Linux users rightly reported that if the jsmin python lib is present on the system (latest 2.0.9) the v8 building fails [1]. This is caused by the SConscript adding its own tools directory in the Python PATH at the end of the PATH. When the tools/js2c.py file is used, it imports the jsmin library which is then loaded from the system and thus the build process doesn't use the bundled one as it should. I apply the attached patch to the v8 SConscript to make sure that it uses first its own shipped libs before trying to use the system's. This affects all 2.4.x versions and 2.6.x versions as well. Please consider applying this fix. [1] https://bugs.gentoo.org/show_bug.cgi?id=510142 |
| Comments |
| Comment by Benety Goh [ 27/May/14 ] |
|
pull request merged. also ported fix to src/third_party/v8-3.25/SConscript |
| Comment by Githook User [ 27/May/14 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: https://github.com/mongodb/mongo/pull/681 The local python patch should be searched at first to avoid conflicts or incompatible libs versions used during the build process. |
| Comment by Githook User [ 27/May/14 ] |
|
Author: {u'name': u'Ultrabug', u'email': u'ultrabug@gentoo.org'}Message: The local python patch should be searched at first to avoid conflicts or incompatible libs versions used during the build process. Signed-off-by: Benety Goh <benety@mongodb.com> |
| Comment by Ultrabug [ 26/May/14 ] |
|
The proposed solution has been also proposed on github pull request #681 |