[SERVER-14184] Unused preprocessor macros from s2 conflict on OS X Yosemite Created: 06/Jun/14 Updated: 11/Mar/15 Resolved: 19/Sep/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 2.6.1 |
| Fix Version/s: | 2.6.6, 2.7.7 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Marc Bachmann | Assignee: | Matt Kangas |
| Resolution: | Done | Votes: | 0 |
| Labels: | community-team | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Yosemite Developer Preview 1 (14A238x) |
||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | OS X | ||||||||
| Backport Completed: | |||||||||
| Steps To Reproduce: | 1. Install OSX Yosemite I did an upgrade from Mavericks. So I'm sorry if you can't reproduce this bug. It's probably my mistake. |
||||||||
| Sprint: | Server 2.7.4, Server 2.7.5, Server 2.7.6 | ||||||||
| Participants: | |||||||||
| Description |
|
The file "src/third_party/s2/util/endian/endian.h" is not compatible with the c compiler on Yosemite. This is the build error I got.
Somehow the last lines (118-189) are the problem. The compilation worked after I’ve removed them. (I couldn’t find a location where those were used anyways) Here is the version of the compiler I used:
How does mongodb handle bugs in third party libraries? |
| Comments |
| Comment by Githook User [ 27/Oct/14 ] | ||
|
Author: {u'username': u'kangas', u'name': u'Matt Kangas', u'email': u'matt.kangas@mongodb.com'}Message: (cherry picked from commit 759b6e8cabfb745b712b5ffd0748561129c3b421) | ||
| Comment by Githook User [ 19/Sep/14 ] | ||
|
Author: {u'username': u'kangas', u'name': u'Matt Kangas', u'email': u'matt.kangas@mongodb.com'}Message: | ||
| Comment by Adrian Petrescu [ 19/Jun/14 ] | ||
|
Just for reference, here is what those macros are defined as, in /usr/include/sys/_endian.h in the latest Yosemite/Xcode beta:
| ||
| Comment by Eric Milkie [ 06/Jun/14 ] | ||
|
Yes, we can definitely remove those unused macros from endian.h. An easy fix! | ||
| Comment by Matt Kangas [ 06/Jun/14 ] | ||
|
Apparently Yosemite added htonll/ntohll? Mavericks doesn't have the "ll" variants. "man 3 byteorder" on Mavericks shows $ man htonll |